Remove serializable from API #9997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: see-quick <maros.orsak159@gmail.com>
Signed-off-by: see-quick <maros.orsak159@gmail.com>
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Frawless
approved these changes
Apr 19, 2024
scholzj
requested changes
Apr 19, 2024
api/src/main/java/io/strimzi/api/kafka/model/bridge/KafkaBridgeAdminClientSpec.java
Outdated
Show resolved
Hide resolved
|
I think you committed here way more than you wanted ... |
…ne at the start of class Signed-off-by: see-quick <maros.orsak159@gmail.com>
see-quick
force-pushed
the
remove-serialize
branch
from
6b15856
to
88a3a6f
Compare
scholzj
approved these changes
Apr 19, 2024
|
/azp run acceptance |
|
Azure Pipelines successfully started running 1 pipeline(s). |
see-quick
added
ready for merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR addresses an issue [1]. TLDR; Remove the
Serializableinterface because It's never serialized using Java serialization.[1] - #2075
Checklist