This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
feat: add info about logging #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributes to: strimzi#24 Signed-off-by: Andrew Borley <borley@uk.ibm.com>
scholzj
approved these changes
Oct 12, 2020
dlabaj
approved these changes
Oct 12, 2020
There was a problem hiding this comment.
LGTM for typescript we can get the types here for pino (https://www.npmjs.com/package/@types/pino)
|
@ajborley would you mind raising an issue to implement the logging? Once done, I will merge this |
This was referenced Oct 12, 2020
rkpattnaik780
pushed a commit
to rkpattnaik780/strimzi-ui
that referenced
this pull request
Feb 9, 2021
fix: add federate view for create wizard
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to: #24
Signed-off-by: Andrew Borley borley@uk.ibm.com