Use TARGETARCH to get supercronic binary per target platform
#1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockdeep
approved these changes
Aug 26, 2023
| ARG ARCH=amd64 | ||
| ENV SUPERCRONIC_URL=https://github.com/aptible/supercronic/releases/download/v0.1.3/supercronic-linux-$ARCH \ | ||
| SUPERCRONIC=supercronic-linux-$ARCH \ | ||
| ARG TARGETARCH |
There was a problem hiding this comment.
How does TARGETARCH get populated? Is id thanks to the platform line in our Github action?
There was a problem hiding this comment.
Sort of - TARGETARCH is one of several pre-defined build arguments (full list here). The platform line is telling Docker which architecture to build for, so in a sense it informs what the value of TARGETARCH is but not its existence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking into how to pass the target arch into a build arg in the Dockerfile, when I found out that it's already available in
TARGETARCH. So instead of usingARCHI renamed everything toTARGETARCHand got a successful amd64 build and arm64 build, with the correct versions of the supercronic binary attached. Here's the GH Actions logs; if you search forsupercronicyou can see L738/739 shows the amd64 build + output, and L1197/1198 shows the arm64 build + output.