Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start to implement checkout session API #648

Merged

Conversation

fauxparse
Copy link
Contributor

This is a very basic start at implementing the checkout session API, just because I needed it in a project I'm working on and I didn't have much time. In particular, a lot of the existing tests failed when I ran them on my machine, and I didn't have much luck digging into why (I see that the build is also failing on master).

Happy to collaborate with someone to take this further, but this is as good a starting point as I can get for now (hopefully better than nothing!)

@chuckphillips
Copy link

@fauxparse Given that Checkout Sessions are generally used with Stripe Checkout and Stripe Webhooks, might you be able to support checkout.session.completed via StripeMock.mock_webhook_event in spec/fixtures/stripe_webhooks/?

@fauxparse
Copy link
Contributor Author

@fauxparse Given that Checkout Sessions are generally used with Stripe Checkout and Stripe Webhooks, might you be able to support checkout.session.completed via StripeMock.mock_webhook_event in spec/fixtures/stripe_webhooks/?

I'll see if I get some time...

@chuckphillips
Copy link

@fauxparse I just read that users can add their own fixture. I tested it and it works, so not critical to add.
https://github.com/rebelidealist/stripe-ruby-mock#customizing-webhooks

@alexmamonchik alexmamonchik merged commit d12621d into stripe-ruby-mock:master Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants