Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to crypto/rand #8

Closed
ChimeraCoder opened this issue Jul 14, 2017 · 1 comment
Closed

Switch to crypto/rand #8

ChimeraCoder opened this issue Jul 14, 2017 · 1 comment

Comments

@ChimeraCoder
Copy link
Collaborator

Since we're not using fixed seeds in tests, there's no reason no use math/rand: #7

pulkitsharma07 added a commit to pulkitsharma07/goforit that referenced this issue Apr 8, 2019
@bobby-stripe
Copy link
Contributor

crypto/rand is still significantly slower here than math/rand unfortunately. In #43 we moved to using a sync.Pool of *math/rand.Rand objects seeded from crypto/rand: https://github.com/stripe/goforit/blob/master/internal/safepool/rand.go#L11-L18 . Going to close this for now, as I think we're still years away from Linux's getrandom improvements being deployed widely enough to directly use crypto/rand here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants