Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated new Bazel BUILD files and hand-corrected core's BUILD #322

Merged
merged 1 commit into from Jan 31, 2019

Conversation

areese-stripe
Copy link
Contributor

Re-ran the sbt bazelGenerate command to create new Bazel BUILD files and hand-corrected rainier-core's BUILD file so buildozer wouldn't complain about unused dependencies. Will work on making this not require hand-correction with sbt-bazel's 0.0.2 release.

@avi-stripe
Copy link
Contributor

This is failing CI on the sbt tut target for reasons that aren't immediately clear to me. Will investigate tonight.

@areese-stripe
Copy link
Contributor Author

Weird. I ran the sbt tut command locally and it was fine.

@codecov-io
Copy link

Codecov Report

Merging #322 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #322   +/-   ##
========================================
  Coverage    46.09%   46.09%           
========================================
  Files           80       80           
  Lines         2727     2727           
  Branches       215      215           
========================================
  Hits          1257     1257           
  Misses        1470     1470

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc3195e...3fbef27. Read the comment docs.

@avi-stripe
Copy link
Contributor

@areese-stripe restarting the build fixed it, so putting it down to some travis flakiness.

@avi-stripe avi-stripe merged commit 311d071 into develop Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants