Use setter method when creating components to track usage of reactsdk #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jojo-stripe
changed the title
jorgea-stripe
approved these changes
Aug 28, 2023
| @@ -10,7 +10,8 @@ | |||
| "removeComments": false, | |||
| "strict": true, | |||
| "forceConsistentCasingInFileNames": true, | |||
| "esModuleInterop": true | |||
| "esModuleInterop": true, | |||
| "resolveJsonModule": true | |||
src/useCreateComponent.tsx
Outdated
| @@ -13,6 +14,7 @@ export const useCreateComponent = ( | |||
|
|
|||
| React.useLayoutEffect(() => { | |||
| if (wrapperDivRef.current !== null && component === null) { | |||
| (connectInstance as any).setReactSdkAnalytics(version); | |||
There was a problem hiding this comment.
We can declare an interface above if to avoid this as any i.e. as IConnectJSWithPrivateMethods. Looking at this also makes me a bit nervous, would you mind doing this in a try catch and simply logging a warning in the try catch? Trying to avoid a possible future incident.
jorgea-stripe
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will track usage of reactsdk and also the package used
Casting the connect instance as any so we don't have to surface this method to the Connect Instance interface