-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use custom setter methods (cherry-pick beta -> master), bump connect-js version #53
use custom setter methods (cherry-pick beta -> master), bump connect-js version #53
Conversation
src/Components.tsx
Outdated
useAttachAttribute( | ||
React.useEffect(() => { | ||
if (!onboarding) return; | ||
onboarding.setRecipientTermsOfServiceUrl(recipientTermsOfServiceUrl); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a bit odd to call all of the setters. Does it make sense to instead have separate useEffects like we had before? We can have a hook wrappers that do that as well, like:
useUpdateWithSetter(onboarding, fullTermsOfServiceUrl, (elem, val) => elem.setFullTermsOfServiceUrl(val));
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaiying-stripe PR looks good, but we are missing the peerDependencies
bump
@@ -46,7 +46,7 @@ | |||
"@babel/preset-flow": "7.18.6", | |||
"@babel/preset-react": "7.18.6", | |||
"@rollup/plugin-replace": "^2.3.1", | |||
"@stripe/connect-js": "2.0.3", | |||
"@stripe/connect-js": "3.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaiying-stripe make sure to also bump the peerDependencies
!
No description provided.