use custom setter methods (cherry-pick beta -> master), bump connect-js version #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgea-stripe
requested changes
Nov 17, 2023
jorgea-stripe
requested changes
Nov 17, 2023
src/Components.tsx
Outdated
| useAttachAttribute( | ||
| React.useEffect(() => { | ||
| if (!onboarding) return; | ||
| onboarding.setRecipientTermsOfServiceUrl(recipientTermsOfServiceUrl); |
There was a problem hiding this comment.
It is a bit odd to call all of the setters. Does it make sense to instead have separate useEffects like we had before? We can have a hook wrappers that do that as well, like:
useUpdateWithSetter(onboarding, fullTermsOfServiceUrl, (elem, val) => elem.setFullTermsOfServiceUrl(val));
jorgea-stripe
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
@kaiying-stripe PR looks good, but we are missing the peerDependencies bump
| @@ -46,7 +46,7 @@ | |||
| "@babel/preset-flow": "7.18.6", | |||
| "@babel/preset-react": "7.18.6", | |||
| "@rollup/plugin-replace": "^2.3.1", | |||
| "@stripe/connect-js": "2.0.3", | |||
| "@stripe/connect-js": "3.0.1", | |||
There was a problem hiding this comment.
@kaiying-stripe make sure to also bump the peerDependencies!
kaiying-stripe
deleted the
kaiying/use-custom-setter-methods-master-cherry-pick
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.