Update stripe-js for Custom Checkout types #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danwang-stripe
force-pushed
the
danwang/bump-stripe-js
branch
from
147c0ca
to
a3a0ae3
Compare
madhav-stripe
requested changes
Mar 4, 2024
package.json
Outdated
| @@ -92,15 +92,15 @@ | |||
| "react-dom": "18.1.0", | |||
| "react-test-renderer": "^18.0.0", | |||
| "rimraf": "^2.6.2", | |||
| "rollup": "^1.27.0", | |||
| "rollup": "^4.12.0", | |||
There was a problem hiding this comment.
@danwang-stripe I don't think we can upgrade rollup in this PR
madhav-stripe
force-pushed
the
danwang/bump-stripe-js
branch
from
c85e1e7
to
947e418
Compare
|
build output on current master: |
danwang-stripe
force-pushed
the
danwang/bump-stripe-js
branch
from
947e418
to
305d099
Compare
|
Merged master in with 776705b Thanks for helping with the dependency upgrades! |
madhav-stripe
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & motivation
Update version of stripe-js to v3.0.7 to pull in new Custom Checkout types
API review
Copy this template or link to an API review issue.
Testing & documentation