Update PaymentController and related classes to take ApiRequest.Options #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of passing a publishable key, pass `ApiRequest.Options` so that a user-specified Connected account (see `Stripe#setAccount()`) is included in requests. MOBILE3DS2-451
This is already done in `ApiRequest.Options`
chander-stripe
approved these changes
Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instead of passing a publishable key, pass
ApiRequest.Optionsso thata user-specified Connected account (see
Stripe#setAccount()) isincluded in requests.
Motivation
MOBILE3DS2-451
Testing
Updated tests and manually verified