Create PaymentIntent.ClientSecret and SetupIntent.ClientSecret for validation #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lidation Confirm a PaymentIntent or SetupIntent will now fail early if an invalid clientSecret is provided. ANDROID-455
aliriaz-stripe
approved these changes
Dec 17, 2019
| internal data class ClientSecret(internal val value: String) { | ||
| internal val paymentIntentId: String = | ||
| value.split("_secret".toRegex()) | ||
| .dropLastWhile { it.isEmpty() }.toTypedArray()[0] |
There was a problem hiding this comment.
not entirely sure how this works but wondering if there is a case where we end up with an empty array here? Or do we ensure an empty array will never be the case with the isEmpty()
There was a problem hiding this comment.
I'm not sure if there are any edge cases this isn't handling, but given that it's the existing logic for obtaining an ID from a client secret, I'm going to leave it as is.
stripe-ci
assigned mshafrir-stripe and unassigned csabol-stripe, yuki-stripe and davidme-stripe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Confirm a PaymentIntent or SetupIntent will now fail early if an
invalid clientSecret is provided.
Motivation
ANDROID-455
Testing
Unit tests + manual testing