Manually parcel PaymentController.Result #2105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary Update `PaymentController.Result`'s parceling logic to manually parcel. This prevents using `Parcel.writeException()`, which is what the autogenerated parceling logic uses. That method only supports certain exception subtypes, and will throw any exception that is unsupported [0]. Motivation Fixes #2100 Testing Added a test to run a `PaymentController.Result` instance through a parceling/unparceling roundtrip. [0] https://developer.android.com/reference/android/os/Parcel#writeException(java.lang.Exception)
markfi-stripe
approved these changes
Jan 27, 2020
stripe-ci
assigned mshafrir-stripe and unassigned csabol-stripe, chander-stripe and markfi-stripe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update
PaymentController.Result's parcelinglogic to manually parcel. This prevents
using
Parcel.writeException(), which iswhat the autogenerated parceling logic uses.
That method only supports certain exception
subtypes, and will throw any exception that
is unsupported.
Motivation
Fixes #2100
Testing
Added a test to run a
PaymentController.Resultinstance through a parceling/unparceling roundtrip.