Enable adding mandate information to confirm params #2112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markfi-stripe
approved these changes
Jan 29, 2020
stripe-ci
assigned mshafrir-stripe and unassigned csabol-stripe, chander-stripe and markfi-stripe
Summary - Update confirm params creation methods to take an optional mandate id or mandate data - Remove `ConfirmPaymentIntentParams.Builder` - Remove `ConfirmSetupIntentParams.Builder` Motivation Fixes #2103 Testing Add unit tests
mshafrir-stripe
force-pushed
the
enable-mandate-params
branch
from
134f772
to
773e9d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
optional mandate id or mandate data
ConfirmPaymentIntentParams.BuilderConfirmSetupIntentParams.BuilderMotivation
Fixes #2103
Testing
Add unit tests