Remove return type from PaymentSession.init() #2163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `PaymentSession.init()` would return `false` if an `IllegalStateException` was thrown. This logic existed because `CustomerSession.getInstance()`, which can throw an exception, was called within `init()`. The `CustomerSession` instance is now injected via the constructor, and will throw an exception at construction time.
mshafrir-stripe
force-pushed
the
ps-init
branch
from
362f5a2
to
643b945
Compare
chander-stripe
approved these changes
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously,
PaymentSession.init()would returnfalseif an
IllegalStateExceptionwas thrown. This logicexisted because
CustomerSession.getInstance(), whichcan throw an exception, was called within
init().The
CustomerSessioninstance is now injected viathe constructor, and will throw an exception at
construction time