Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ShippingInfoWidget #2336

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Improve ShippingInfoWidget #2336

merged 1 commit into from
Mar 30, 2020

Conversation

mshafrir-stripe
Copy link
Collaborator

@mshafrir-stripe mshafrir-stripe commented Mar 30, 2020 •
edited

  • Make postal code and phone number single line
  • Make phone number use inputType="phone"

@mshafrir-stripe
Improve ShippingInfoWidget
6cca9c0 
- Make postal code and phone number single line
- Make postal code use `inputType="phone"`
@mshafrir-stripe mshafrir-stripe merged commit ca934fd into master Mar 30, 2020
@mshafrir-stripe mshafrir-stripe deleted the improve-shipping-widget branch March 30, 2020 19:53
@mshafrir-stripe mshafrir-stripe mentioned this pull request Mar 31, 2020
Closed
@oproulx
Copy link

oproulx commented Mar 31, 2020

Postal code still needs to accept letters + numbers for Canada.

@mshafrir-stripe
Copy link
Collaborator Author

@oproulx the second bullet in the commit message was incorrect, it should have read

Make phone number use inputType="phone"

I changed it to this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chander-stripe chander-stripe chander-stripe approved these changes

Assignees

@mshafrir-stripe mshafrir-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mshafrir-stripe @oproulx @chander-stripe @stripe-ci