Target API 30 #2611
Merged
Target API 30 #2611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chander-stripe
previously approved these changes
Jun 23, 2020
|
hmm.. it looks like there's a bug in robolectric on android 11 where |
|
Same issue with AndroidJUnit4 runner |
|
alright, the issue seems to be related to the fact that I removed the targetSdkVersion. AFAICT, libraries shouldn't need to specify a targetSdkVersion (that's determined by the app, not the library) but on the other hand, it doesn't appear to cause any issues (and we were doing it before anyway). If it causes weird robolectric issues when we remove it, then it seems like we should probably just keep it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Testing