Add UPI Payment method support #2955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshafrir-stripe
requested changes
Oct 21, 2020
.idea/codestyles/Project.xml
Outdated
| <package name="kotlinx.android.synthetic" alias="false" withSubpackages="true" /> | ||
| </value> | ||
| </option> | ||
| <option name="PACKAGES_IMPORT_LAYOUT"> | ||
| <value> | ||
| <package name="" alias="false" withSubpackages="true" /> | ||
| <package name="java" alias="false" withSubpackages="true" /> | ||
| <package name="javax" alias="false" withSubpackages="true" /> | ||
| <package name="kotlin" alias="false" withSubpackages="true" /> | ||
| <package name="" alias="true" withSubpackages="true" /> | ||
| <package name="kotlinx.android.synthetic" withSubpackages="true" static="false" /> |
example/AndroidManifest.xml
Outdated
| @@ -13,7 +13,6 @@ | |||
| <application | |||
| android:icon="@mipmap/ic_launcher" | |||
| android:label="@string/appName" | |||
| android:name=".ExampleApplication" | |||
| @@ -0,0 +1,11 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" | |||
There was a problem hiding this comment.
use <FrameLayout>
| @@ -89,6 +89,13 @@ internal object PaymentMethodCreateParamsFixtures { | |||
| billingDetails = BILLING_DETAILS | |||
| ) | |||
|
|
|||
| internal val UPI = PaymentMethodCreateParams.create( | |||
There was a problem hiding this comment.
remove extra space
| }.orEmpty() | ||
| } | ||
|
|
||
| class Builder : ObjectBuilder<Upi> { |
| ) | ||
|
|
||
| stripe = Stripe(applicationContext, "pk_live_51H7wmsBte6TMTRd45LsWj9e3Kfkw6Kzlf5KhSrewsRydlElo8VarJxoIalKr5ielPeKf8erWZmt0qihjlwNux03y00c1zZpnxb") | ||
| // stripe = Stripe(applicationContext, "pk_test_51H7wmsBte6TMTRd4gph9Wm7gnQOKJwdVTCj30AhtB8MhWtlYj6v9xDn1vdCtKYGAE7cybr6fQdbQQtgvzBihE9cl00tOnrTpL9") |
|
|
||
|
|
||
| class UPIPaymentActivity : AppCompatActivity() { | ||
| private lateinit var stripe: Stripe |
There was a problem hiding this comment.
private val stripe by lazy { ... }
| import com.stripe.example.databinding.UpiPaymentActivityBinding | ||
|
|
||
|
|
||
| class UPIPaymentActivity : AppCompatActivity() { |
There was a problem hiding this comment.
rename to UpiPaymentActivity
| override fun onCreate(savedInstanceState: Bundle?) { | ||
| super.onCreate(savedInstanceState) | ||
| setContentView(viewBinding.root) | ||
| stripe = Stripe(applicationContext, "pk_live_51H7wmsBte6TMTRd45LsWj9e3Kfkw6Kzlf5KhSrewsRydlElo8VarJxoIalKr5ielPeKf8erWZmt0qihjlwNux03y00c1zZpnxb") |
There was a problem hiding this comment.
remove hardcoded key
| ) | ||
| ) | ||
|
|
||
| stripe = Stripe(applicationContext, "pk_live_51H7wmsBte6TMTRd45LsWj9e3Kfkw6Kzlf5KhSrewsRydlElo8VarJxoIalKr5ielPeKf8erWZmt0qihjlwNux03y00c1zZpnxb") |
There was a problem hiding this comment.
remove hardcoded key
anirudh-stripe
force-pushed
the
anirudh/upi-integration
branch
from
ed6a088
to
17d5fe5
Compare
mshafrir-stripe
requested changes
Oct 23, 2020
| @@ -0,0 +1,11 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android" | |||
| android:orientation="vertical" android:layout_width="match_parent" | |||
There was a problem hiding this comment.
remove android:orientation
| android:layout_height="match_parent"> | ||
|
|
||
| <TextView | ||
| android:id="@+id/paymentStatus" |
There was a problem hiding this comment.
@+id/payment_status
|
|
||
| class UpiPaymentActivity : AppCompatActivity() { | ||
| private val stripe by lazy { | ||
| Stripe(applicationContext, "pk_live_51H7wmsBte6TMTRd45LsWj9e3Kfkw6Kzlf5KhSrewsRydlElo8VarJxoIalKr5ielPeKf8erWZmt0qihjlwNux03y00c1zZpnxb") |
There was a problem hiding this comment.
StripeFactory(application).create()
| upi = PaymentMethodCreateParams.Upi( | ||
| vpa = viewBinding.vpa.text.toString() | ||
| ), billingDetails = PaymentMethod.BillingDetails( | ||
| name = "Anirudh Bhargava", |
| import com.stripe.example.databinding.UpiPaymentActivityBinding | ||
|
|
||
|
|
||
| class UpiPaymentActivity : AppCompatActivity() { |
There was a problem hiding this comment.
StripeIntentActivity
Comment on lines
47
to
50
| val confirmParams = ConfirmPaymentIntentParams | ||
| .createWithPaymentMethodCreateParams(params, "pi_1HekzlBte6TMTRd4ndk9lqQv_secret_gYrLPEgcRO3PMg7E1wEC1CJRC") | ||
|
|
||
| stripe.confirmPayment(this, confirmParams) |
There was a problem hiding this comment.
replace with
createAndConfirmPaymentIntent("in", params)
| import com.stripe.example.databinding.UpiWaitingActivityBinding | ||
|
|
||
| class UpiWaitingActivity : AppCompatActivity() { | ||
| private lateinit var stripe: Stripe |
There was a problem hiding this comment.
private val stripe by lazy { StripeFactory(application).create() }
| } | ||
| }).start() | ||
|
|
||
| } |
There was a problem hiding this comment.
You can implement onResume() (similar to onCreate()) to query for the PaymentIntent whenever the activity is foregrounded.
Comment on lines
66
to
69
| if (!(paymentIntent.clientSecret.isNullOrBlank())) { | ||
| val intent = Intent(applicationContext, UpiWaitingActivity::class.java) | ||
| startActivity(intent) | ||
| } |
There was a problem hiding this comment.
startActivity(
Intent(this@UpiPaymentActivity, UpiWaitingActivity::class.java)
.putExtra(EXTRA_CLIENT_SECRET, paymentIntent.clientSecret)
)
|
|
||
| override fun onCreate(savedInstanceState: Bundle?) { | ||
| super.onCreate(savedInstanceState) | ||
| setContentView(viewBinding.root) |
There was a problem hiding this comment.
add
val clientSecret = intent.extras?.getString(EXTRA_CLIENT_SECRET)
if (clientSecret == null) {
finish()
return
}
mshafrir-stripe
requested changes
Oct 26, 2020
stripe/src/test/java/com/stripe/android/model/PaymentMethodCreateParamsFixtures.kt
Outdated
Show resolved
Hide resolved
…-integration # Conflicts: # stripe/src/main/java/com/stripe/android/model/PaymentMethod.kt # stripe/src/main/java/com/stripe/android/model/PaymentMethodCreateParams.kt # stripe/src/main/java/com/stripe/android/model/parsers/PaymentMethodJsonParser.kt # stripe/src/test/java/com/stripe/android/ApiKeyFixtures.kt # stripe/src/test/java/com/stripe/android/model/PaymentMethodCreateParamsFixtures.kt
| @@ -541,6 +570,16 @@ data class PaymentMethodCreateParams internal constructor( | |||
| return PaymentMethodCreateParams(sofort, billingDetails, metadata) | |||
| } | |||
|
|
|||
| @JvmSynthetic | |||
There was a problem hiding this comment.
Did you mean @JvmStatic?
mshafrir-stripe
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Testing