Fix CvcEditText layout issues in CardMultilineWidget #3154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CvcEditText` sets hint text by default, but this clashes with the `CvcEditText`'s `TextInputLayout` in `CardMultilineWidget`. Remove hint text from the `CvcEditText`. Use `onAttachedToWindow()` instead of `onFinishInflate()` to handle `CardMultilineWidget` instantiated via layout or in code. Fixes #3147
chander-stripe
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CvcEditTextsets hint text by default, but this clashes withthe
CvcEditText'sTextInputLayoutinCardMultilineWidget.Remove hint text from the
CvcEditText.Use
onAttachedToWindow()instead ofonFinishInflate()to handleCardMultilineWidgetinstantiated via layout or in code.Fixes #3147