Add PaymentAuthWebViewActivity.onAuthComplete() #3493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshafrir-stripe
requested review from
michelleb-stripe,
ccen-stripe and
brnunes-stripe
This method will be called when `PaymentAuthWebViewClient` signals that auth is complete (whether succeeded or failed). When auth failed due to an error, update the result of `PaymentAuthWebViewActivity` accordingly. Delete redundant `PaymentAuthWebViewTest`
mshafrir-stripe
force-pushed
the
on-auth-complete
branch
from
8b3dadc
to
6ed6e48
Compare
stripe-ci
assigned mshafrir-stripe and unassigned brnunes-stripe, michelleb-stripe and ccen-stripe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This method will be called when
PaymentAuthWebViewClientsignalsthat auth is complete (whether succeeded or failed).
When auth failed due to an error, update the result of
PaymentAuthWebViewActivityaccordingly.Delete redundant
PaymentAuthWebViewTestMotivation
Return correct result
Testing