Invoke issuing API requests on background thread #3507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously requests were being fired on the main thread (`runBlocking`). Move requests to a background thread and dispatch results on main thread. Fixes #3499
| @@ -8,15 +8,20 @@ import com.stripe.android.Stripe.Companion.appInfo | |||
| import com.stripe.android.exception.InvalidRequestException | |||
| import com.stripe.android.networking.StripeApiRepository | |||
| import com.stripe.android.networking.StripeRepository | |||
| import kotlinx.coroutines.runBlocking | |||
| import kotlinx.coroutines.CoroutineScope | |||
There was a problem hiding this comment.
I am curious how you found this? DO we have checks in place to make sure it doesn't happen other places?
There was a problem hiding this comment.
did a quick search, it looks like apart from the synchronous calls here, there is no prod code using runBlocking
ccen-stripe
requested changes
Mar 23, 2021
stripe/src/main/java/com/stripe/android/IssuingCardPinService.kt
Outdated
Show resolved
Hide resolved
stripe/src/test/java/com/stripe/android/IssuingCardPinServiceTest.kt
Outdated
Show resolved
Hide resolved
stripe-ci
assigned mshafrir-stripe and unassigned brnunes-stripe, michelleb-stripe and ccen-stripe
|
LGTM |
ccen-stripe
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously requests were being fired on the main thread
(
runBlocking). Move requests to a background thread and dispatchresults on main thread.
Motivation
Fixes #3499
Testing