Call the card input widget focus listener when focus is gained. #3520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+770
to
+775
| postalCodeEditText.internalFocusChangeListeners.add { _, hasFocus -> | ||
| if (hasFocus) { | ||
| scrollEnd() | ||
| cardInputListener?.onFocusChange(CardInputListener.FocusField.PostalCode) | ||
| } | ||
| } |
There was a problem hiding this comment.
Does this need to be applied to CardMultilineWidget as well?
There was a problem hiding this comment.
good news is that it is covered there already.
mshafrir-stripe
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When the focus on postal code is entered the card input widget focus listener callback should be called. The CardInputListener.FocusField already included PostalCode as a field that could change, but the callback was never being called. Care was taken to make sure that this didn't impact the postal code validation on the field.
Motivation
Requested by a user of the card input widget.
Testing