Introduce suspend fun for Stripe Android SDK - part2
#3568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebarrenechea-stripe
previously approved these changes
Apr 8, 2021
There was a problem hiding this comment.
LGTM!
The data comment is not a blocker but might be worth while investigating. IMO, the caller should determine if it has an Intent instance before calling the extension functions and handle that case appropriately. It may result in a better API or may end up complicating things too much on the calling code.
|
@ccen-stripe can you hold off on merging this? I'd like to 👀 . |
mshafrir-stripe
requested changes
Apr 8, 2021
stripe/src/main/java/com/stripe/android/StripePaymentController.kt
Outdated
Show resolved
Hide resolved
stripe/src/main/java/com/stripe/android/StripePaymentController.kt
Outdated
Show resolved
Hide resolved
mshafrir-stripe
requested changes
Apr 13, 2021
stripe/src/test/java/com/stripe/android/StripePaymentAuthTest.kt
Outdated
Show resolved
Hide resolved
mshafrir-stripe
requested changes
Apr 13, 2021
mshafrir-stripe
previously approved these changes
Apr 13, 2021
mshafrir-stripe
approved these changes
Apr 13, 2021
This was referenced Apr 15, 2021
ccen-stripe
changed the title
suspend fun for Stripe Android SDK - part2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduce
suspend funfor all existing Stripe APIs.Note: the doc linked to in this PR is internal only
This is a follow up change on #3557, for the changes in 'get' APIs, the following changes are made:
isForPaymentintentResult,isForSetupIntentResultinStripe.kt, checking ifresultCodeandIntentis for requiredStripeModelgetPaymentIntentResult,getSetupIntentResultandgetSourceinPaymentControllergetPaymentIntentResult,getSetupIntentResultandgetSourceinStripeKtx.ktby invoking the functions above, retrievingStripeModelfromresultCodeandIntenton activity resultWill add these to the example app in a follow up PR.
Motivation
For details, please refer to this doc
Fixes #2642
Testing