Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade androidx.recyclerview:recyclerview to 1.2.0 #3575

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

mshafrir-stripe
Copy link
Collaborator

Summary

https://developer.android.com/jetpack/androidx/releases/recyclerview#recyclerview-1.2.0

Replace deprecated ViewHolder.getAdapterPosition with
ViewHolder.getBindingAdapterPosition

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

https://developer.android.com/jetpack/androidx/releases/recyclerview#recyclerview-1.2.0

Replace deprecated `ViewHolder.getAdapterPosition` with
`ViewHolder.getBindingAdapterPosition`
Copy link
Contributor

@michelleb-stripe michelleb-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@mshafrir-stripe mshafrir-stripe merged commit 526942c into master Apr 8, 2021
@mshafrir-stripe mshafrir-stripe deleted the upgrade-recycler-view branch April 8, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants