Deprecate ConfirmPaymentIntentParams extraParams parameter #3635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`extraParams` were previously used to set `setupFutureUsage`. [0] We now have a `setupFutureUsage` property, so there's no use for this property. Add overloaded "create" methods without an `extraParams` property and mark the variant with the property as deprecated. [0] https://stripe.com/docs/payments/save-during-payment?platform=android#android-submit-payment
ccen-stripe
requested changes
Apr 27, 2021
stripe/src/main/java/com/stripe/android/model/ConfirmPaymentIntentParams.kt
Outdated
Show resolved
Hide resolved
stripe-ci
assigned mshafrir-stripe and unassigned brnunes-stripe, michelleb-stripe and ccen-stripe
stripe/src/main/java/com/stripe/android/model/ConfirmPaymentIntentParams.kt
Outdated
Show resolved
Hide resolved
stripe/src/test/java/com/stripe/android/model/ConfirmPaymentIntentParamsTest.kt
Outdated
Show resolved
Hide resolved
brnunes-stripe
approved these changes
Apr 28, 2021
ccen-stripe
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extraParamswere previously used to setsetupFutureUsage. [0]We now have a
setupFutureUsageproperty, so there's no use for thisproperty.
Add overloaded "create" methods without an
extraParamsproperty andmark the variant with the property as deprecated.
[0] https://stripe.com/docs/payments/save-during-payment?platform=android#android-submit-payment