Use StripeBrowserLauncherActivity when Chrome is available #3663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `StripeBrowserLauncherActivity` was only used when the device had Custom Tabs support. Expand support to include devices that don't have Custom Tabs but do have Chrome installed. Rename `CustomTabsCapabilities` to `BrowserCapabilitiesSupplier`. This PR adds a `<queries />` entry for the Chrome package. This is required by Android 11.
michelleb-stripe
approved these changes
Apr 30, 2021
| --> | ||
| <queries> | ||
| <!-- | ||
| Added to check if Chrome is installed for browser-based payment authentication (e.g. 3DS1). |
There was a problem hiding this comment.
The checking mechanism for custom tabs is a little different from the best practice described here:
https://developer.chrome.com/docs/android/custom-tabs/best-practices/#preparing-for-other-browsers
There was a problem hiding this comment.
I'm adding this for when Custom Tabs is not available.
You do bring up a good point though! We should verify behavior when multiple browsers support Custom Tabs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously,
StripeBrowserLauncherActivitywas only used whenthe device had Custom Tabs support. Expand support to include
devices that don't have Custom Tabs but do have Chrome installed.
Rename
CustomTabsCapabilitiestoBrowserCapabilitiesSupplier.This PR adds a
<queries />entry for the Chrome package. This isrequired by Android 11.
Motivation
Continue migration away from WebViews for browser-based authentication.
Testing
Screenshots
Demonstration of behavior when Custom Tabs are not available and Chrome is installed: