Upgrade Android Gradle Plugin to 4.2.0 #3677
Merged
+4
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release notes: https://developer.android.com/studio/releases/gradle-plugin#4-2-0 - Remove dexcount plugin because it is incompatible with 4.2.0. This plugin hasn't had a release since October 2020, so it's likely that it will be some time before the plugin is made compatible. We don't rely on this plugin so it's safe to remove. - Fix tests that are failing due to new changes in how string resources are processed. String resources that are defined with the closing tag on a new line line now include a whitesppace character at the end of the string. ```xml <!-- Resolves to "Some text" in AGP 4.1.2 Resolves to "Some text " in AGP 4.2.0 --> <string name="my_string"> Some text </string> ```
mshafrir-stripe
requested review from
brnunes-stripe,
ccen-stripe and
michelleb-stripe
as code owners
mshafrir-stripe
changed the title
ccen-stripe
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Release notes: https://developer.android.com/studio/releases/gradle-plugin#4-2-0
Remove
dexcount-gradle-pluginbecause it is incompatible with 4.2.0.This plugin hasn't had a release since October 2020, so it's likely that
it will be some time before the plugin is made compatible.
We don't rely on this plugin so it's safe to remove.
Fix tests that are failing due to new changes in how string resources
are processed. String resources that are defined with the closing
tag on a new line line now include a whitespace character at the end
of the string.
Motivation
Testing