Set canCancelSource=true in StripeBrowserLauncherViewModel result #3681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `PaymentAuthWebViewActivityViewModel#cancellationResult` we set `canCancelSource=true` and conditionally set `shouldCancelIntentOnUserNavigation`. In `StripeBrowserLauncherViewModel`, we have no way to tell what action the customer took during 3DS1, whether cancel, succeed, or fail. That means the source is always cancellable.
mshafrir-stripe
requested review from
brnunes-stripe,
ccen-stripe and
michelleb-stripe
as code owners
| * We don't want to cancel if required actions have been resolved and the payment is ready | ||
| * for capture. | ||
| */ | ||
| private fun shouldCancelIntent( |
There was a problem hiding this comment.
Awesome, great to see this as a function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In
PaymentAuthWebViewActivityViewModel#cancellationResultwe setcanCancelSource=trueand conditionally setshouldCancelIntentOnUserNavigation.In
StripeBrowserLauncherViewModel, we have no way to tell whataction the customer took during 3DS1, whether cancel, succeed, or fail.
That means the source is always cancellable.
Motivation
Ensure PaymentIntent and SetupIntent objects are correctly cancelled.
Testing