Add Stripe.createRadarSession() API binding #3737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for creating a Radar Session through `/v1/radar/sessions`. `Stripe.advancedFraudSignalsEnabled` must be set to `true` (i.e. the default value) to use this method.
mshafrir-stripe
requested review from
brnunes-stripe,
ccen-stripe and
michelleb-stripe
as code owners
mshafrir-stripe
requested review from
davidme-stripe,
yuki-stripe and
drapeau-stripe
ccen-stripe
requested changes
May 19, 2021
| import java.util.Calendar | ||
| import kotlin.coroutines.CoroutineContext | ||
|
|
||
| internal interface FingerprintDataRepository { | ||
| @UiThread |
There was a problem hiding this comment.
should this be @WorkerThread ?
There was a problem hiding this comment.
@UiThread because it is safe to call from the main thread.
There was a problem hiding this comment.
hmm from the doc a method is annotated with @UiThread only when it has to be run on ui thread - but it seems #refresh doesn't have to be called on ui thread right?
stripe-ci
assigned mshafrir-stripe and unassigned brnunes-stripe, michelleb-stripe and ccen-stripe
ccen-stripe
requested changes
May 19, 2021
| import java.util.Calendar | ||
| import kotlin.coroutines.CoroutineContext | ||
|
|
||
| internal interface FingerprintDataRepository { | ||
| @UiThread |
There was a problem hiding this comment.
hmm from the doc a method is annotated with @UiThread only when it has to be run on ui thread - but it seems #refresh doesn't have to be called on ui thread right?
ccen-stripe
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for creating a Radar Session through
/v1/radar/sessions.Stripe.advancedFraudSignalsEnabledmust betrue(i.e.the default value) to use this method.
Motivation
RUN_MOBILESDK-200
Testing