Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish CardFormView #3761

Merged
merged 2 commits into from
May 26, 2021
Merged

publish CardFormView #3761

merged 2 commits into from
May 26, 2021

Conversation

ccen-stripe
Copy link
Collaborator

Summary

CFV passed implementation review, publish it in the next release

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Copy link
Contributor

@michelleb-stripe michelleb-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Copy link
Contributor

@michelleb-stripe michelleb-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems fitting to have an example in our example application, so people can test it out and have an example of integrating it in their app.

Both one where you dynamically create the view and read it from xml would be awesome.

@ccen-stripe ccen-stripe merged commit 7a55a3e into master May 26, 2021
@ccen-stripe ccen-stripe deleted the cfv branch May 26, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants