Implement support for SetupIntents #3762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brnunes-stripe
requested review from
ccen-stripe,
michelleb-stripe and
mshafrir-stripe
as code owners
|
PR to merge into |
brnunes-stripe
commented
May 25, 2021
payments-core/src/main/java/com/stripe/android/paymentsheet/PaymentSheetViewModel.kt
Show resolved
Hide resolved
ccen-stripe
previously requested changes
May 26, 2021
...core/src/main/java/com/stripe/android/networking/paymentsheet/model/StripeIntentValidator.kt
Outdated
Show resolved
Hide resolved
...core/src/main/java/com/stripe/android/networking/paymentsheet/model/StripeIntentValidator.kt
Outdated
Show resolved
Hide resolved
...core/src/main/java/com/stripe/android/networking/paymentsheet/model/StripeIntentValidator.kt
Outdated
Show resolved
Hide resolved
...s-core/src/main/java/com/stripe/android/paymentsheet/flowcontroller/DefaultFlowController.kt
Outdated
Show resolved
Hide resolved
...s-core/src/main/java/com/stripe/android/paymentsheet/flowcontroller/DefaultFlowController.kt
Outdated
Show resolved
Hide resolved
payments-core/src/main/java/com/stripe/android/paymentsheet/viewmodels/BaseSheetViewModel.kt
Outdated
Show resolved
Hide resolved
payments-core/src/main/java/com/stripe/android/paymentsheet/PaymentSheetViewModel.kt
Outdated
Show resolved
Hide resolved
payments-core/src/main/java/com/stripe/android/paymentsheet/PaymentSheetViewModel.kt
Outdated
Show resolved
Hide resolved
payments-core/src/main/java/com/stripe/android/paymentsheet/PaymentSheetViewModel.kt
Outdated
Show resolved
Hide resolved
payments-core/src/main/java/com/stripe/android/paymentsheet/PaymentSheetViewModel.kt
Show resolved
Hide resolved
stripe-ci
assigned brnunes-stripe and unassigned mshafrir-stripe, michelleb-stripe and ccen-stripe
brnunes-stripe
assigned mshafrir-stripe, michelleb-stripe and ccen-stripe and unassigned brnunes-stripe
michelleb-stripe
previously approved these changes
May 27, 2021
# Conflicts: # payments-core/src/main/java/com/stripe/android/payments/PaymentFlowResultProcessor.kt # payments-core/src/main/java/com/stripe/android/paymentsheet/PaymentSheetViewModel.kt # payments-core/src/main/java/com/stripe/android/paymentsheet/flowcontroller/DefaultFlowController.kt # payments-core/src/main/java/com/stripe/android/paymentsheet/flowcontroller/DefaultFlowControllerInitializer.kt # payments-core/src/main/java/com/stripe/android/paymentsheet/flowcontroller/FlowControllerFactory.kt # payments-core/src/main/java/com/stripe/android/paymentsheet/flowcontroller/InitData.kt # payments-core/src/test/java/com/stripe/android/paymentsheet/PaymentSheetActivityTest.kt # payments-core/src/test/java/com/stripe/android/paymentsheet/PaymentSheetViewModelTest.kt # payments-core/src/test/java/com/stripe/android/paymentsheet/flowcontroller/DefaultFlowControllerTest.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Generalize PaymentIntent usage with StripeIntent, which can also represent a SetupIntent.
Re-add SetupIntent entry points.
Motivation
Support for SetupIntents in PaymentSheet.
Testing