Clear error message when new payment method is selected #3978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brnunes-stripe
requested review from
ccen-stripe,
michelleb-stripe and
mshafrir-stripe
as code owners
michelleb-stripe
previously requested changes
Jul 13, 2021
stripe-ci
assigned brnunes-stripe and unassigned mshafrir-stripe, michelleb-stripe and ccen-stripe
I think so, as long as it stays on screen until the user takes an action, which is the case with this change. What do you think? |
ccen-stripe
previously approved these changes
Jul 13, 2021
brnunes-stripe
force-pushed
the
brnunes/error2
branch
from
591ed8c
to
034e7e0
Compare
ccen-stripe
requested changes
Jul 16, 2021
...s-core/src/main/java/com/stripe/android/paymentsheet/PaymentSheetAddPaymentMethodFragment.kt
Outdated
Show resolved
Hide resolved
payments-core/src/main/java/com/stripe/android/paymentsheet/PaymentSheetViewModel.kt
Outdated
Show resolved
Hide resolved
ccen-stripe
approved these changes
Jul 16, 2021
payments-core/src/main/java/com/stripe/android/paymentsheet/BaseAddPaymentMethodFragment.kt
Show resolved
Hide resolved
| @@ -177,12 +177,12 @@ internal class PaymentSheetActivity : BaseSheetActivity<PaymentSheetResult>() { | |||
|
|
|||
| override fun onBackPressed() { | |||
| if (supportFragmentManager.backStackEntryCount > 0) { | |||
| updateErrorMessage(null) | |||
| updateErrorMessage() | |||
There was a problem hiding this comment.
Just a stylistic thing here, I realize you can use default arguments, but without the null parameter passed in here, it is hard to realize that the side-effect of this function is that the error message will be cleared.
payments-core/src/main/java/com/stripe/android/paymentsheet/PaymentSheetActivity.kt
Show resolved
Hide resolved
| } | ||
|
|
There was a problem hiding this comment.
If order is important here, a comment would be helpful.
| _viewState.value = PaymentSheetViewState.Reset(null) | ||
| if (this.checkoutIdentifier != checkoutIdentifier) { | ||
| // Clear out any previous errors before setting the new button to get updates. | ||
| _viewState.value = PaymentSheetViewState.Reset() |
There was a problem hiding this comment.
This comments says it clears previous errors, but it seems like ti doesn't because in the activities we are also clearing the error message?
payments-core/src/main/java/com/stripe/android/paymentsheet/PaymentSheetViewModel.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Previously the error message was shown even after the user selects a different payment method.
Testing