Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependency to RxJava #4035

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Remove unused dependency to RxJava #4035

merged 1 commit into from
Jul 21, 2021

Conversation

brnunes-stripe
Copy link
Contributor

Summary

Remove unused dependency to RxJava.

Motivation

Fix #4027

Testing

  • Added tests
  • Modified tests
  • Manually verified

@github-actions
Copy link
Contributor

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: none)
NEW: paymentsheet-example-release-pr.apk (signature: none)

          │             compressed             │          uncompressed           
          ├───────────┬───────────┬────────────┼───────────┬──────────┬──────────
 APK      │ old       │ new       │ diff       │ old       │ new      │ diff     
──────────┼───────────┼───────────┼────────────┼───────────┼──────────┼──────────
      dex │    12 MiB │  11.4 MiB │ -525.3 KiB │  40.4 MiB │   39 MiB │ -1.4 MiB 
     arsc │   1.3 MiB │   1.3 MiB │        0 B │   1.3 MiB │  1.3 MiB │      0 B 
 manifest │   2.5 KiB │   2.5 KiB │        0 B │  10.5 KiB │ 10.5 KiB │      0 B 
      res │ 695.6 KiB │ 695.6 KiB │        0 B │     1 MiB │    1 MiB │      0 B 
    asset │   9.3 KiB │   9.3 KiB │        0 B │  15.8 KiB │ 15.8 KiB │      0 B 
    other │ 151.1 KiB │ 150.6 KiB │     -440 B │ 308.1 KiB │  308 KiB │    -89 B 
──────────┼───────────┼───────────┼────────────┼───────────┼──────────┼──────────
    total │  14.1 MiB │  13.6 MiB │ -525.8 KiB │  43.1 MiB │ 41.6 MiB │ -1.4 MiB 


         │           raw            │                unique                
         ├────────┬────────┬────────┼────────┬────────┬────────────────────
 DEX     │ old    │ new    │ diff   │ old    │ new    │ diff               
─────────┼────────┼────────┼────────┼────────┼────────┼────────────────────
   files │      3 │      3 │      0 │        │        │                    
 strings │ 184045 │ 176921 │  -7124 │ 169979 │ 164551 │  -5428 (+0 -5428)  
   types │  33066 │  31107 │  -1959 │  31386 │  29631 │  -1755 (+0 -1755)  
 classes │  29030 │  27353 │  -1677 │  29030 │  27353 │  -1677 (+0 -1677)  
 methods │ 168697 │ 157405 │ -11292 │ 164303 │ 153431 │ -10872 (+0 -10872) 
  fields │ 113532 │ 107578 │  -5954 │ 113216 │ 107289 │  -5927 (+0 -5927)  


 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  293 │  293 │  0   
 entries │ 4292 │ 4292 │  0
APK
      compressed       │     uncompressed      │                                                             
──────────┬────────────┼──────────┬────────────┤                                                             
 size     │ diff       │ size     │ diff       │ path                                                        
──────────┼────────────┼──────────┼────────────┼─────────────────────────────────────────────────────────────
  1.6 MiB │ -673.9 KiB │  4.1 MiB │   -1.9 MiB │ ∆ classes3.dex                                              
  3.5 MiB │   +156 KiB │ 10.1 MiB │ +546.9 KiB │ ∆ classes2.dex                                              
  6.3 MiB │   -7.4 KiB │ 24.8 MiB │  -32.6 KiB │ ∆ classes.dex                                               
          │     -237 B │          │      -78 B │ - META-INF/runtime-rxjava2_release.kotlin_module            
          │     -205 B │          │      -11 B │ - META-INF/androidx.compose.runtime_runtime-rxjava2.version 
   37 KiB │       +2 B │ 36.8 KiB │        0 B │ ∆ okhttp3/internal/publicsuffix/publicsuffixes.gz           
──────────┼────────────┼──────────┼────────────┼─────────────────────────────────────────────────────────────
 11.5 MiB │ -525.8 KiB │   39 MiB │   -1.4 MiB │ (total)
DEX
STRINGS:

   old    │ new    │ diff             
  ────────┼────────┼──────────────────
   169979 │ 164551 │ -5428 (+0 -5428) 
  
  - �
  
  ���
  
  ���
  ���*��
  �2�0�J�����0�H�¨��¸��
  - H
  
  ���
  ���
  ���
  ���
  ���
  ���
  ���
  ���
  ���
  ���
  ���
  ���
  
  ���
  
  ���
  
  ���
  ����Y�������H�0����������*�H�2�����H�2+�����%����H���������H�����0�0�����0	0�¢���
  H��¢�������������0
  0�*�0�H�¢�����5�������H�0����������*�H�*�����H�0�2�����H�H�¢�����5�������H�0����������*�H�*�����H�0�2�����H�H�¢�����5�������H�0����������*�H�*�����H�0�2�����H�H�¢�����5�������H�0����������*�H�*�����H�0�2�����H�H�¢����¨��
  - _disposable_inlined
  - _subscribe
  - _this_asState
  - (Lio/reactivex/Completable;Landroidx/compose/runtime/Composer;I)Landroidx/compose/runtime/State;
  - (Lio/reactivex/Flowable;Ljava/lang/Object;Landroidx/compose/runtime/Composer;I)Landroidx/compose/runtime/State;
  - (Lio/reactivex/Maybe;Ljava/lang/Object;Landroidx/compose/runtime/Composer;I)Landroidx/compose/runtime/State;
  - (Lio/reactivex/Observable;Ljava/lang/Object;Landroidx/compose/runtime/Composer;I)Landroidx/compose/runtime/State;
  - (Lio/reactivex/Single;Ljava/lang/Object;Landroidx/compose/runtime/Composer;I)Landroidx/compose/runtime/State;
  - >(TS;TT;
  - >;TS;
  - C(asState)133@5663L36,134@5704L149:RxJava2Adapter.kt#wvx965
  - C(subscribeAsState)109@4693L34:RxJava2Adapter.kt#wvx965
  - C(subscribeAsState)126@5450L59:RxJava2Adapter.kt#wvx965
  - C(subscribeAsState)49@1994L34:RxJava2Adapter.kt#wvx965
  - C(subscribeAsState)69@2904L34:RxJava2Adapter.kt#wvx965
  - C(subscribeAsState)89@3789L34:RxJava2Adapter.kt#wvx965
  - Landroidx/compose/runtime/rxjava2/R;
  - Landroidx/compose/runtime/rxjava2/RxJava2AdapterKt_asState_1_disposable_1;
  - Landroidx/compose/runtime/rxjava2/RxJava2AdapterKt_asState_1_invoke__inlined_onDispose_1;
  - Landroidx/compose/runtime/rxjava2/RxJava2AdapterKt_asState_1;
  - Landroidx/compose/runtime/rxjava2/RxJava2AdapterKt_sam_i_io_reactivex_functions_Consumer_0;
  - Landroidx/compose/runtime/rxjava2/RxJava2AdapterKt_subscribeAsState__inlined_asState_1_1;
  - Landroidx/compose/runtime/rxjava2/RxJava2AdapterKt_subscribeAsState__inlined_asState_1_2;
  - Landroidx/compose/runtime/rxjava2/RxJava2AdapterKt_subscribeAsState__inlined_asState_1;
  - Landroidx/compose/runtime/rxjava2/RxJava2AdapterKt_subscribeAsState__inlined_asState_2_1;
  - Landroidx/compose/runtime/rxjava2/RxJava2AdapterKt_subscribeAsState__inlined_asState_2_2;
  - Landroidx/compose/runtime/rxjava2/RxJava2AdapterKt_subscribeAsState__inlined_asState_2;
  - Landroidx/compose/runtime/rxjava2/RxJava2AdapterKt_subscribeAsState__inlined_asState_3_1;
  - Landroidx/compose/runtime/rxjava2/RxJava2AdapterKt_subscribeAsState__inlined_asState_3_2;
  - Landroidx/compose/runtime/rxjava2/RxJava2AdapterKt_subscribeAsState__inlined_asState_3;
  - Landroidx/compose/runtime/rxjava2/RxJava2AdapterKt_subscribeAsState__inlined_asState_4_1;
  - Landroidx/compose/runtime/rxjava2/RxJava2AdapterKt_subscribeAsState__inlined_asState_4_2;
  - Landroidx/compose/runtime/rxjava2/RxJava2AdapterKt_subscribeAsState__inlined_asState_4;
  - Landroidx/compose/runtime/rxjava2/RxJava2AdapterKt_subscribeAsState__inlined_asState_5_1;
  - Landroidx/compose/runtime/rxjava2/RxJava2AdapterKt_subscribeAsState__inlined_asState_5_2;
  - Landroidx/compose/runtime/rxjava2/RxJava2AdapterKt_subscribeAsState__inlined_asState_5;
  - Landroidx/compose/runtime/rxjava2/RxJava2AdapterKt_subscribeAsState_5_1;
  - Landroidx/compose/runtime/rxjava2/RxJava2AdapterKt;
  - Lio/reactivex/Completable;
  - Lio/reactivex/Flowable;
  - Lio/reactivex/Flowable<
  - Lio/reactivex/Maybe;
  - Lio/reactivex/Maybe<
  - Lio/reactivex/Observable;
  - Lio/reactivex/Observable<
  - Lio/reactivex/Single;
  - Lio/reactivex/Single<
  - Lio/reactivex/disposables/Disposable;
  - Lio/reactivex/functions/Action;
  - Lio/reactivex/functions/Consumer;
  - RxJava2Adapter.kt
  - SMAP
  Effects.kt
  Kotlin
  *S Kotlin
  *F
  + 1 Effects.kt
  androidx/compose/runtime/DisposableEffectScope_onDispose_1
  + 2 RxJava2Adapter.kt
  androidx/compose/runtime/rxjava2/RxJava2AdapterKt_asState_1
  *L
  1#1,483:1
  139#2:484
  *E
  
  - SMAP
  RxJava2Adapter.kt
  Kotlin
  *S Kotlin
  *F
  + 1 RxJava2Adapter.kt
  androidx/compose/runtime/rxjava2/RxJava2AdapterKt
  + 2 Composables.kt
  androidx/compose/runtime/ComposablesKt
  + 3 Composer.kt
  androidx/compose/runtime/ComposerKt
  *L
  1#1,143:1
  134#1:144
  135#1,7:152
  134#
...✂

@brnunes-stripe brnunes-stripe merged commit eee877a into master Jul 21, 2021
@brnunes-stripe brnunes-stripe deleted the brnunes/rxjava branch July 21, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] dependency to rxjava since 17.0.0
2 participants