Support deleting saved payment methods #4108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brnunes-stripe
requested review from
ccen-stripe,
michelleb-stripe and
mshafrir-stripe
as code owners
brnunes-stripe
force-pushed
the
brnunes/delete
branch
from
64006a5
to
cd8a0cb
Compare
|
Diffuse output: |
brnunes-stripe
force-pushed
the
brnunes/delete
branch
from
cd8a0cb
to
4d14762
Compare
ccen-stripe
requested changes
Aug 17, 2021
payments-core/src/main/java/com/stripe/android/paymentsheet/viewmodels/BaseSheetViewModel.kt
Show resolved
Hide resolved
payments-core/src/main/java/com/stripe/android/paymentsheet/ui/BaseSheetActivity.kt
Show resolved
Hide resolved
payments-core/src/main/java/com/stripe/android/paymentsheet/BasePaymentMethodsListFragment.kt
Outdated
Show resolved
Hide resolved
payments-core/src/main/java/com/stripe/android/paymentsheet/BasePaymentMethodsListFragment.kt
Outdated
Show resolved
Hide resolved
payments-core/src/main/java/com/stripe/android/paymentsheet/BasePaymentMethodsListFragment.kt
Show resolved
Hide resolved
payments-core/src/main/java/com/stripe/android/paymentsheet/PaymentOptionsAdapter.kt
Show resolved
Hide resolved
payments-core/src/main/java/com/stripe/android/paymentsheet/PaymentSheetActivity.kt
Show resolved
Hide resolved
payments-core/res/layout/layout_paymentsheet_payment_method_item.xml
Outdated
Show resolved
Hide resolved
payments-core/src/main/java/com/stripe/android/paymentsheet/PaymentOptionsAdapter.kt
Show resolved
Hide resolved
payments-core/src/main/java/com/stripe/android/paymentsheet/viewmodels/BaseSheetViewModel.kt
Show resolved
Hide resolved
# Conflicts: # payments-core/src/main/java/com/stripe/android/paymentsheet/PaymentOptionsViewModel.kt
ccen-stripe
requested changes
Aug 17, 2021
payments-core/src/main/java/com/stripe/android/paymentsheet/PaymentOptionsAdapter.kt
Show resolved
Hide resolved
ccen-stripe
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support deleting saved payment methods.
Motivation
Let users delete their saved payment methods from Payment Sheet.
Testing
Screenshots
device-2021-08-13-185536.mp4