Pre-Populate the form #4124
Merged
Pre-Populate the form #4124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate form field values.
…ate form field values.
…to populate form field values." This reverts commit c9489e8.
michelleb-stripe
requested review from
brnunes-stripe,
ccen-stripe and
mshafrir-stripe
as code owners
michelleb-stripe
assigned brnunes-stripe and ccen-stripe and unassigned brnunes-stripe and ccen-stripe
|
Diffuse output: |
yuki-stripe
reviewed
Aug 23, 2021
| /** | ||
| * The billing information for the user. | ||
| * | ||
| * If set, PaymentSheet will pre-populate the form fiels with the values provided. |
There was a problem hiding this comment.
Suggested change
| * If set, PaymentSheet will pre-populate the form fiels with the values provided. | |
| * If set, PaymentSheet will pre-populate the form fields with the values provided. |
| city = "San Francisco", | ||
| state = "CA", | ||
| postalCode = "94111", | ||
| country = "DE", |
There was a problem hiding this comment.
Is "DE" with a US address on purpose?
There was a problem hiding this comment.
yeah, United States is the default.
There was a problem hiding this comment.
I switched it to a Dublin address
| ) : Parcelable | ||
|
|
||
| @Parcelize | ||
| data class Address( |
There was a problem hiding this comment.
Is this being redefined just because of the dependency direction? Will it change to be the PaymentSheet.Address?
payments-core/src/main/java/com/stripe/android/paymentsheet/BaseAddPaymentMethodFragment.kt
Outdated
Show resolved
Hide resolved
|
FYI this is the iOS implementation https://github.com/stripe-ios/stripe-ios/pull/335 |
brnunes-stripe
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pre-Populate the form with billing details.
Motivation
Testing
Screenshots