Migrate Custom Payment Sheet Example to PaymentLauncher

[skyler-stripe]

Summary

• Change PaymentController to PaymentLauncher within DefaultFlowController
• Update tests to reflect changes.

Motivation

PaymentLauncher is a more modern api that gives us a few advantages over PaymentController. PaymentLauncher is more simple to use as it does not require us to handle the interim flows with PaymentFlowProcessor. It also uses ActivityResultLauncher which gives us more reliable result callbacks over startActivityForResult/onActivityResult.

doc on this project

Testing

• Added tests
• Modified tests
• Manually verified

Recording

[ccen-stripe]

Now that PaymentController and FlowResultProcessors are no longer needed in any of the PaymentSheet logic, we can delete them from dagger graph.

Line 74-137 here can be all deleted. @brnunes-stripe as discussed, I think this would make it easier to inject productUsage :)

Also we can make remove the @RestrictTo annotation of PaymentController, PaymentFlowResultProcessor and PaymentIntentFlowResultProcessor, then make them internal as they no longer needs to be visible to paymentsheet module. There might be more classes that could be made internal here, cc-ing @michelleb-stripe for more pointers

[skyler-stripe]

Now that PaymentController and FlowResultProcessors are no longer needed in any of the PaymentSheet logic, we can delete them from dagger graph.

Line 74-137 here can be all deleted. @brnunes-stripe as discussed, I think this would make it easier to inject productUsage :)

Also we can make remove the @RestrictTo annotation of PaymentController, PaymentFlowResultProcessor and PaymentIntentFlowResultProcessor, then make them internal as they no longer needs to be visible to paymentsheet module. There might be more classes that could be made internal here, cc-ing @michelleb-stripe for more pointers

Does it make sense to do this in this PR? I was thinking I'd do a third PR to clean out the no longer needed stuff and change some of the internals based on @michelleb-stripe 's comment on my last PR. #4159 (comment)

[skyler-stripe]

Now that PaymentController and FlowResultProcessors are no longer needed in any of the PaymentSheet logic, we can delete them from dagger graph.

Line 74-137 here can be all deleted. @brnunes-stripe as discussed, I think this would make it easier to inject productUsage :)

Also we can make remove the @RestrictTo annotation of PaymentController, PaymentFlowResultProcessor and PaymentIntentFlowResultProcessor, then make them internal as they no longer needs to be visible to paymentsheet module. There might be more classes that could be made internal here, cc-ing @michelleb-stripe for more pointers

done in e328c29

will make a follow up PR to look more deeply into things we can restrict.

[brnunes-stripe]

Will it ever fall here? Aren't all options covered above?