Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump lifecycle-viewmodel-compose from 1.0.0-alpha07 to 2.4.0-rc01 #4198

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 16, 2021

Bumps lifecycle-viewmodel-compose from 1.0.0-alpha07 to 2.4.0-rc01.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps lifecycle-viewmodel-compose from 1.0.0-alpha07 to 2.4.0-beta01.

---
updated-dependencies:
- dependency-name: androidx.lifecycle:lifecycle-viewmodel-compose
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 16, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2021

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: none)
NEW: paymentsheet-example-release-pr.apk (signature: none)

          │          compressed           │           uncompressed            
          ├───────────┬───────────┬───────┼─────────────┬─────────────┬───────
 APK      │ old       │ new       │ diff  │ old         │ new         │ diff  
──────────┼───────────┼───────────┼───────┼─────────────┼─────────────┼───────
      dex │  11.6 MiB │  11.6 MiB │ +72 B │    39.4 MiB │    39.4 MiB │ -56 B 
     arsc │   1.4 MiB │   1.4 MiB │   0 B │     1.4 MiB │     1.4 MiB │   0 B 
 manifest │   2.5 KiB │   2.5 KiB │  -1 B │    10.5 KiB │    10.5 KiB │   0 B 
      res │ 641.6 KiB │ 641.6 KiB │  +2 B │ 1,003.4 KiB │ 1,003.4 KiB │   0 B 
    asset │  77.6 KiB │  77.6 KiB │  +1 B │   109.1 KiB │   109.1 KiB │  +1 B 
    other │    78 KiB │    78 KiB │  -7 B │     154 KiB │     154 KiB │  -3 B 
──────────┼───────────┼───────────┼───────┼─────────────┼─────────────┼───────
    total │  13.7 MiB │  13.7 MiB │ +67 B │      42 MiB │      42 MiB │ -58 B 


         │          raw           │            unique            
         ├────────┬────────┬──────┼────────┬────────┬────────────
 DEX     │ old    │ new    │ diff │ old    │ new    │ diff       
─────────┼────────┼────────┼──────┼────────┼────────┼────────────
   files │      3 │      3 │    0 │        │        │            
 strings │ 179459 │ 179458 │   -1 │ 166280 │ 166279 │ -1 (+1 -2) 
   types │  31648 │  31648 │    0 │  29998 │  29998 │  0 (+0 -0) 
 classes │  27702 │  27702 │    0 │  27702 │  27702 │  0 (+0 -0) 
 methods │ 159892 │ 159892 │    0 │ 155554 │ 155554 │  0 (+0 -0) 
  fields │ 108844 │ 108844 │    0 │ 108490 │ 108490 │  0 (+0 -0) 


 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  293 │  293 │  0   
 entries │ 4348 │ 4348 │  0
APK
   compressed    │   uncompressed   │                                                                   
─────────┬───────┼──────────┬───────┤                                                                   
 size    │ diff  │ size     │ diff  │ path                                                              
─────────┼───────┼──────────┼───────┼───────────────────────────────────────────────────────────────────
 6.3 MiB │ +72 B │ 24.8 MiB │ -56 B │ ∆ classes.dex                                                     
   215 B │  -3 B │     11 B │  -3 B │ ∆ META-INF/androidx.lifecycle_lifecycle-viewmodel-compose.version 
   184 B │  -2 B │      6 B │   0 B │ ∆ META-INF/androidx.activity_activity-compose.version             
   200 B │  -2 B │      6 B │   0 B │ ∆ META-INF/androidx.lifecycle_lifecycle-viewmodel-ktx.version     
   502 B │  +2 B │    404 B │   0 B │ ∆ res/06.png                                                      
 5.4 KiB │  +1 B │  5.3 KiB │  +1 B │ ∆ assets/dexopt/baseline.prof                                     
 2.5 KiB │  -1 B │ 10.5 KiB │   0 B │ ∆ AndroidManifest.xml                                             
─────────┼───────┼──────────┼───────┼───────────────────────────────────────────────────────────────────
 6.4 MiB │ +67 B │ 24.8 MiB │ -58 B │ (total)
MANIFEST
@@ -1,4 +1,4 @@
 <manifest
-    android:compileSdkVersion=30
-    android:compileSdkVersionCodename=11
+    android:compileSdkVersion=31
+    android:compileSdkVersionCodename=12
     android:versionCode=1
@@ -6,4 +6,4 @@
     package=com.stripe.android.paymentsheet.example
-    platformBuildVersionCode=30
-    platformBuildVersionName=11
+    platformBuildVersionCode=31
+    platformBuildVersionName=12
     xmlns:android=http://schemas.android.com/apk/res/android
@@ -12,3 +12,3 @@
       android:minSdkVersion=21
-      android:targetSdkVersion=30
+      android:targetSdkVersion=31
       />
DEX
STRINGS:

   old    │ new    │ diff       
  ────────┼────────┼────────────
   166280 │ 166279 │ -1 (+1 -2) 
  
  + C40@1551L7,41@1616L7:LocalViewModelStoreOwner.kt#3tja67
  
  - 41@1616L7
  - C40@1551L7:LocalViewModelStoreOwner.kt#3tja67

Copy link
Contributor

@skyler-stripe skyler-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to give us the same problems as other android repos. We won't be able to see source code and suggestions in the IDE. Is that something we want?

@brnunes-stripe
Copy link
Contributor

This is going to give us the same problems as other android repos. We won't be able to see source code and suggestions in the IDE. Is that something we want?

Robolectric also doesn't work with 31, need to explicitly set to 30. This upgrade can wait IMO.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 30, 2021

A newer version of androidx.lifecycle:lifecycle-viewmodel-compose exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@michelleb-stripe
Copy link
Contributor

This is going to give us the same problems as other android repos. We won't be able to see source code and suggestions in the IDE. Is that something we want?

@skyler-stripe Is this because the gradle version or android gradle plugin needs to be updated? Also I believe terminal had a fix for this. If it is the same issue we can probably dig up that PR.

@skyler-stripe
Copy link
Contributor

This is going to give us the same problems as other android repos. We won't be able to see source code and suggestions in the IDE. Is that something we want?

@skyler-stripe Is this because the gradle version or android gradle plugin needs to be updated? Also I believe terminal had a fix for this. If it is the same issue we can probably dig up that PR.

@michelle-stripe I think now that the sources are out we'd be okay. Let me take a look at this one and get back with an answer.

@skyler-stripe skyler-stripe self-assigned this Oct 14, 2021
…ndroidx.lifecycle-lifecycle-viewmodel-compose-2.4.0-beta01
@brnunes-stripe brnunes-stripe changed the title Bump lifecycle-viewmodel-compose from 1.0.0-alpha07 to 2.4.0-beta01 Bump lifecycle-viewmodel-compose from 1.0.0-alpha07 to 2.4.0-rc01 Oct 19, 2021
brnunes-stripe and others added 3 commits October 19, 2021 13:58
…ycle-lifecycle-viewmodel-compose-2.4.0-beta01' into dependabot/gradle/androidx.lifecycle-lifecycle-viewmodel-compose-2.4.0-beta01
@brnunes-stripe brnunes-stripe merged commit 7053906 into master Oct 19, 2021
@brnunes-stripe brnunes-stripe deleted the dependabot/gradle/androidx.lifecycle-lifecycle-viewmodel-compose-2.4.0-beta01 branch October 19, 2021 22:29
@brnunes-stripe
Copy link
Contributor

This is going to give us the same problems as other android repos. We won't be able to see source code and suggestions in the IDE. Is that something we want?

@skyler-stripe Is this because the gradle version or android gradle plugin needs to be updated? Also I believe terminal had a fix for this. If it is the same issue we can probably dig up that PR.

@michelle-stripe I think now that the sources are out we'd be okay. Let me take a look at this one and get back with an answer.

It was just because the source for 31 wasn't available yet, it is now.
I've submitted this, had to set Robolectric SDK to 30 because it doesn't support 31 yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants