CardInputWidget.CardValidCallback will consider the postal code in validation. #4202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelleb-stripe
requested review from
brnunes-stripe,
ccen-stripe and
mshafrir-stripe
as code owners
michelleb-stripe
force-pushed
the
michelleb/cardInputWidget
branch
from
a81080c
to
79b8aff
Compare
michelleb-stripe
assigned brnunes-stripe and ccen-stripe and unassigned michelleb-stripe
ccen-stripe
approved these changes
Sep 20, 2021
| @@ -197,7 +200,7 @@ class CardInputWidget @JvmOverloads constructor( | |||
|
|
|||
| /** | |||
| * A [PaymentMethodCreateParams] representing the card details and postal code if all fields | |||
| * are valid; otherwise `null` | |||
| * are valid; otherwise `null`. If a field is invalid focus will shift to the invalid field | |||
There was a problem hiding this comment.
nit: missing a . here
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With this change the CardValidCallback for CardInputWidget will only report isValid = true if CardNumber, CVC, and ExpiryDate are valid, and if either postalCodeRequired or usZipCodeRequired is true and the postalCodeEnabled (aka visible) isValid will only be true if it passes postal code validation.
The cardParams when queried will change focus to any invalid fields. This is as it is currently designed. If not wanting focus to change to invalid fields cardParams, paymentMethodCreateParams, and paymentMethodCard should only be called when CardValidCallback returns true (which will not be correctly reported). The comments in the code have been updated to reflect this.
Testing