Create test mode indicator #4214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diffuse output: |
skyler-stripe
changed the title
skyler-stripe
requested review from
brnunes-stripe,
ccen-stripe,
michelleb-stripe and
mshafrir-stripe
as code owners
|
Thanks for the change, this is a public UI change to production users, just wondering do we have a UI sign-off on this? |
working on this now |
brnunes-stripe
previously requested changes
Sep 23, 2021
stripe-ci
assigned skyler-stripe and unassigned brnunes-stripe, michelleb-stripe and ccen-stripe
ccen-stripe
previously approved these changes
Sep 24, 2021
ccen-stripe
approved these changes
Sep 24, 2021
skyler-stripe
dismissed
brnunes-stripe’s stale review
fixed issue. afraid of red merge button.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a text view at the top of sheet activities that shows if the user is in testmode or not. If the
Intenthas aliveModeof false then we will show the view.I tried to model it after the iOS version as much as possible.
Motivation
It's nice to know your payment sheet implementation is working on test mode, plus iOS and Web already have this view.
Testing
Screenshots