When processing Result for a PI, refresh until reaches deterministic state #4296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccen-stripe
requested review from
brnunes-stripe,
michelleb-stripe and
skyler-stripe
as code owners
ccen-stripe
force-pushed
the
fixWeChat2
branch
from
1153d78
to
1d719de
Compare
yuki-stripe
reviewed
Oct 19, 2021
payments-core/src/main/java/com/stripe/android/payments/PaymentFlowResultProcessor.kt
Show resolved
Hide resolved
skyler-stripe
previously approved these changes
Oct 19, 2021
payments-core/src/main/java/com/stripe/android/payments/PaymentFlowResultProcessor.kt
Outdated
Show resolved
Hide resolved
| requestOptions | ||
| ) | ||
| ) | ||
| while (stripeIntent.requiresAction() && remainingRetries > 0) { |
There was a problem hiding this comment.
We could make this remainingRetries >= 1 and then we don't have to subtract 1 at the beginning. Kinda messes with my brain a bit. Thoughts?
skyler-stripe
approved these changes
Oct 19, 2021
| } | ||
|
|
||
| if (stripeIntent.requiresAction()) { | ||
| throw MaxRetryReachedException() |
There was a problem hiding this comment.
Where does this exception get caught?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For some payment methods, after user confirmation(resulting in
flowOutCome == SUCCEEDED), there is a delay when Stripe backend transfers its state out ofrequires_action. For a PaymentIntent with such payment method, we will need to poll the refresh endpoint until the PaymentIntent reaches a deterministic state.Current wechat pay is the only payment method that requires this. Other payment methods(e.g UPI, see this internal doc for details) might also need this.
For more details, please see this, this and this internal doc
Motivation
relaunch wechat pay
Testing
Screenshots