Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert toast to snackbar in examples #4354

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Convert toast to snackbar in examples #4354

merged 1 commit into from
Nov 5, 2021

Conversation

skyler-stripe
Copy link
Contributor

Summary

Changes out the toasts that popup with the result to snackbars.

Motivation

Toasts work kind of inconsistently on emulators plus I think the snackbar is better.

See: https://jira.corp.stripe.com/browse/MOBILESDK-398

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
output output

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2021

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: none)
NEW: paymentsheet-example-release-pr.apk (signature: none)

          │           compressed           │             uncompressed             
          ├───────────┬───────────┬────────┼─────────────┬─────────────┬──────────
 APK      │ old       │ new       │ diff   │ old         │ new         │ diff     
──────────┼───────────┼───────────┼────────┼─────────────┼─────────────┼──────────
      dex │  11.7 MiB │  11.7 MiB │ -618 B │    39.8 MiB │    39.8 MiB │ +1.2 KiB 
     arsc │   1.3 MiB │   1.3 MiB │    0 B │     1.3 MiB │     1.3 MiB │      0 B 
 manifest │   2.6 KiB │   2.6 KiB │    0 B │    10.6 KiB │    10.6 KiB │      0 B 
      res │ 640.9 KiB │ 640.9 KiB │    0 B │ 1,020.7 KiB │ 1,020.7 KiB │      0 B 
    asset │  77.8 KiB │  77.8 KiB │  +20 B │   109.3 KiB │   109.3 KiB │    +20 B 
    other │    78 KiB │    78 KiB │   -4 B │     154 KiB │     154 KiB │      0 B 
──────────┼───────────┼───────────┼────────┼─────────────┼─────────────┼──────────
    total │  13.9 MiB │  13.9 MiB │ -602 B │    42.4 MiB │    42.4 MiB │ +1.2 KiB 


         │          raw           │             unique             
         ├────────┬────────┬──────┼────────┬────────┬──────────────
 DEX     │ old    │ new    │ diff │ old    │ new    │ diff         
─────────┼────────┼────────┼──────┼────────┼────────┼──────────────
   files │      3 │      3 │    0 │        │        │              
 strings │ 182316 │ 182350 │  +34 │ 168365 │ 168368 │ +3 (+15 -12) 
   types │  32181 │  32187 │   +6 │  30436 │  30436 │  0 (+0 -0)   
 classes │  28117 │  28117 │    0 │  28117 │  28117 │  0 (+0 -0)   
 methods │ 163018 │ 163033 │  +15 │ 158457 │ 158465 │ +8 (+8 -0)   
  fields │ 109682 │ 109686 │   +4 │ 109330 │ 109331 │ +1 (+1 -0)   


 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  287 │  287 │  0   
 entries │ 4351 │ 4351 │  0
APK 
     compressed      │    uncompressed     │                                                       
─────────┬───────────┼─────────┬───────────┤                                                       
 size    │ diff      │ size    │ diff      │ path                                                  
─────────┼───────────┼─────────┼───────────┼───────────────────────────────────────────────────────
 3.4 MiB │ -19.6 KiB │  10 MiB │ -41.6 KiB │ ∆ classes2.dex                                        
   2 MiB │   +19 KiB │ 5.1 MiB │ +42.8 KiB │ ∆ classes3.dex                                        
 5.6 KiB │     +20 B │ 5.4 KiB │     +20 B │ ∆ assets/dexopt/baseline.prof                         
   184 B │      -4 B │     6 B │       0 B │ ∆ META-INF/androidx.activity_activity-compose.version 
─────────┼───────────┼─────────┼───────────┼───────────────────────────────────────────────────────
 5.4 MiB │    -602 B │  15 MiB │  +1.2 KiB │ (total)
DEX 
STRINGS:

   old    │ new    │ diff         
  ────────┼────────┼──────────────
   168365 │ 168368 │ +3 (+15 -12) 
  
  + :
  ���
  ���
  ���
  ���
  ���
  ���
  ���
  ���
  
  ���
  ���
  ���
  ���
  ���
  ���� � �2�0�:��B�¢����J��
  ��0�2�����0�H�J_����0�2�����������0�����0�����0�0�H�R�����0�X��¢��
  ������R�����0�8DX���¢�
  �������	�
  ¨��
  + ()Lcom/google/android/material/snackbar/Snackbar;
  + SMAP
  BasePaymentSheetActivity.kt
  Kotlin
  *S Kotlin
  *F
  + 1 BasePaymentSheetActivity.kt
  com/stripe/android/paymentsheet/example/samples/activity/BasePaymentSheetActivityKt
  + 2 Row.kt
  androidx/compose/foundation/layout/RowKt
  + 3 Layout.kt
  androidx/compose/ui/layout/LayoutKt
  + 4 CompositionLocal.kt
  androidx/compose/runtime/CompositionLocal
  + 5 Composables.kt
  androidx/compose/runtime/ComposablesKt
  + 6 Dp.kt
  androidx/compose/ui/unit/DpKt
  + 7 Column.kt
  androidx/compose/foundation/layout/ColumnKt
  *L
  1#1,281:1
  69#2,6:282
  75#2:312
  79#2:354
  69#2,6:355
  75#2:385
  79#2:390
  68#2,7:391
  75#2:422
  70#2,5:423
  75#2:452
  79#2:458
  79#2:463
  72#3:288
  73#3,9:290
  72#3:320
  73#3,9:322
  84#3:348
  84#3:353
  72#3:361
  73#3,9:363
  84#3:389
  72#3:398
  73#3,9:400
  72#3:428
  73#3,9:430
  84#3:457
  84#3:462
  76#4:289
  76#4:321
  76#4:362
  76#4:399
  76#4:429
  418#5,13:299
  418#5,13:331
  431#5,3:345
  431#5,3:350
  418#5,13:372
  431#5,3:386
  418#5,13:409
  418#5,13:439
  431#5,3:454
  431#5,3:459
  155#6:313
  155#6:453
  155#6:464
  155#6:465
  155#6:466
  68#7,6:314
  74#7:344
  78#7:349
  *S KotlinDebug
  *F
  + 1 BasePaymentSheetActivity.kt
  com/stripe/android/paymentsheet/example/samples/activity/BasePaymentSheetActivityKt
  *L
  147#1:282,6
  147#1:312
  147#1:354
  183#1:355,6
  183#1:385
  183#1:390
  211#1:391,7
  211#1:422
  220#1:423,5
  220#1:452
  220#1:458
  211#1:463
  147#1:288
  147#1:290,9
  156#1:320
  156#1:322,9
  156#1:348
  147#1:353
  183#1:361
  183#1:363,9
  183#1:389
  211#1:398
  211#1:400,9
  220#1:428
  220#1:430,9
  220#1:457
  211#1:462
  147#1:289
  156#1:321
  183#1:362
  211#1:399
  220#1:429
  147#1:299,13
  156#1:331,13
  156#1:345,3
  147#1:350,3
  183#1:372,13
  183#1:386,3
  211#1:409,13
  220#1:439,13
  220#1:454,3
  211#1:459,3
  153#1:313
  232#1:453
  256#1:464
  277#1:465
  90#1:466
  156#1:314,6
  156#1:344
  156#1:349
  *E
  
  + SMAP
  BasePaymentSheetActivity.kt
  Kotlin
  *S Kotlin
  *F
  + 1 BasePaymentSheetActivity.kt
  com/stripe/android/paymentsheet/example/samples/activity/BasePaymentSheetActivityKt_Receipt_1
  + 2 Dp.kt
  androidx/compose/ui/unit/DpKt
  + 3 Column.kt
  androidx/compose/foundation/layout/ColumnKt
  + 4 Layout.kt
  androidx/compose/ui/layout/LayoutKt
  + 5 CompositionLocal.kt
  androidx/compose/runtime/CompositionLocal
  + 6 Composables.kt
  androidx/compose/runtime/ComposablesKt
  *L
  1#1,281:1
  155#2:282
  155#2:283
  155#2:315
  155#2:316
  155#2:317
  68#3,6:284
  74#3:314
  68#3,6:318
  74#3:348
  78#3:353
  78#3:358
  72#4:290
  73#4,9:292
  72#4:324
  73#4,9:326
  84#4:352
  84#4:357
  76#5:291
  76#5:325
  418#6,13:301
  418#6,13:335
  431#6,3:349
  431#6,3:354
  *S KotlinDebug
  *F
  + 1 BasePaymentSheetActivity.kt
  com/stripe/android/paymentsheet/example/samples/activity/BasePaymentSheetActivityKt_Receipt_1
  *L
  106#1:282
  107#1:283
  110#1:315
  112#1:316
  118#1:317
  104#1:284,6
  104#1:314
  128#1:318,6
  128#1:348
  128#1:353
  104#1:358
  104#1:290
  104#1:292,9
  128#1:324
  128#1:326,9
  128#1:352
  104#1:357
  104#1:291
  128#1:325
  104#1:301,13
  128#1:335,13
  128#1:349,3
  104#1:354,3
  *E
  
  + SMAP
  BasePaymentSheetActivity.kt
  Kotlin
  *S Kotlin
  *F
  + 1 BasePaymentSheetActivity.kt
  com/stripe/android/paymentsheet/example/samples/activity/ComposableSingletons_BasePaymentSheetActivityKt_lambda-1_1
  + 2 Column.kt
  androidx/compose/foundation/layout/ColumnKt
  + 3 Layout.kt
  androidx/compose/ui/layout/LayoutKt
  + 4 CompositionLocal.kt
  androidx/compose/runtime/CompositionLocal
  + 5 Composables.kt
  androidx/compose/runtime/ComposablesKt
  *L
  1#1,281:1
  68#2,6:282
  74#2:312
  78#2:317
  72#3:288
  73#3,9:290
  84#3:316
  76#4:289
  418#5,13:299
  431#5,3:313
  *S KotlinDebug
  *F
  + 1 BasePaymentSheetActivity.kt
  com/stripe/android/paymentsheet/example/samples/activity/ComposableSingletons_BasePaymentSheetActivityKt_lambda-1_1
  *L
  121#1:282,6
  121#1:312
  121#1:317
  121#1:288
  121#1:290,9
  121#1:316
  121#1:289
  121#1:299,13
  121#1:313,3
  *E

...✂

@skyler-stripe skyler-stripe merged commit adc83cf into master Nov 5, 2021
@skyler-stripe skyler-stripe deleted the snackbar branch November 5, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccen-stripe ccen-stripe ccen-stripe approved these changes

@brnunes-stripe brnunes-stripe Awaiting requested review from brnunes-stripe

@michelleb-stripe michelleb-stripe Awaiting requested review from michelleb-stripe

Assignees

@brnunes-stripe brnunes-stripe

@michelleb-stripe michelleb-stripe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@skyler-stripe @ccen-stripe @brnunes-stripe @michelleb-stripe @bruno-stripe