Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert static height on cmw text boxes #4408

Merged
merged 1 commit into from
Nov 24, 2021
Merged

revert static height on cmw text boxes #4408

merged 1 commit into from
Nov 24, 2021

Conversation

skyler-stripe
Copy link
Contributor

Summary

This reverts my change here: #4266

Motivation

We've been getting some user issues: #4389

Making the text boxes wrap_content for CardMultilineWidget is okay now that we'll have a compose version of the card payment form for payment sheet. Then we won't need the height of CardMultilineWidget static for payment sheet. We'll be able to set text box heights independently of other UIs and keep it uniform across all payment sheet PM forms. For now with this change, the text boxes will be slightly taller but CardMultilineWidget users will not see cutoff text. (until this pr #4358 then the issue will go away completely)

This also fixes a spacing issue where the new card icons were sitting on the divider lines with no spacing.

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
psbefore psafter
examplebefore exampleafter

@github-actions
Copy link
Contributor

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: none)
NEW: paymentsheet-example-release-pr.apk (signature: none)

          │          compressed          │         uncompressed          
          ├───────────┬───────────┬──────┼───────────┬───────────┬───────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff  
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼───────
      dex │  11.7 MiB │  11.7 MiB │  0 B │  39.9 MiB │  39.9 MiB │   0 B 
     arsc │   1.4 MiB │   1.4 MiB │  0 B │   1.4 MiB │   1.4 MiB │   0 B 
 manifest │   2.6 KiB │   2.6 KiB │  0 B │  10.6 KiB │  10.6 KiB │   0 B 
      res │ 653.3 KiB │ 653.3 KiB │ +4 B │     1 MiB │     1 MiB │ +80 B 
    asset │  77.8 KiB │  77.8 KiB │  0 B │ 109.3 KiB │ 109.3 KiB │   0 B 
    other │    78 KiB │    78 KiB │  0 B │   154 KiB │   154 KiB │   0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼───────
    total │  13.9 MiB │  13.9 MiB │ +4 B │  42.5 MiB │  42.5 MiB │ +80 B 


         │          raw           │           unique            
         ├────────┬────────┬──────┼────────┬────────┬───────────
 DEX     │ old    │ new    │ diff │ old    │ new    │ diff      
─────────┼────────┼────────┼──────┼────────┼────────┼───────────
   files │      3 │      3 │    0 │        │        │           
 strings │ 182315 │ 182315 │    0 │ 168464 │ 168464 │ 0 (+0 -0) 
   types │  32279 │  32279 │    0 │  30559 │  30559 │ 0 (+0 -0) 
 classes │  28233 │  28233 │    0 │  28233 │  28233 │ 0 (+0 -0) 
 methods │ 163675 │ 163675 │    0 │ 159156 │ 159156 │ 0 (+0 -0) 
  fields │ 110204 │ 110204 │    0 │ 109862 │ 109862 │ 0 (+0 -0) 


 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  287 │  287 │  0   
 entries │ 4364 │ 4364 │  0
APK
  compressed  │  uncompressed   │              
───────┬──────┼─────────┬───────┤              
 size  │ diff │ size    │ diff  │ path         
───────┼──────┼─────────┼───────┼──────────────
 993 B │ +4 B │ 2.8 KiB │ +80 B │ ∆ res/AE.xml 
───────┼──────┼─────────┼───────┼──────────────
 993 B │ +4 B │ 2.8 KiB │ +80 B │ (total)

@skyler-stripe skyler-stripe merged commit 7072146 into master Nov 24, 2021
@skyler-stripe skyler-stripe deleted the cmwtext branch November 24, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants