Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow non-terminal state for PaymentSheet #4438

Merged
merged 4 commits into from
Dec 9, 2021
Merged

Conversation

ccen-stripe
Copy link
Collaborator

Summary

Allow non terminal state for PaymentSheet

Motivation

RUN_MOBILESDK-584

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2021

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: none)
NEW: paymentsheet-example-release-pr.apk (signature: none)

          │           compressed           │          uncompressed          
          ├───────────┬───────────┬────────┼───────────┬───────────┬────────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff   
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
      dex │  11.8 MiB │  11.8 MiB │ +150 B │  40.1 MiB │  40.1 MiB │ -180 B 
     arsc │   1.4 MiB │   1.4 MiB │    0 B │   1.4 MiB │   1.4 MiB │    0 B 
 manifest │   2.6 KiB │   2.6 KiB │    0 B │  10.7 KiB │  10.7 KiB │    0 B 
      res │ 653.3 KiB │ 653.3 KiB │    0 B │     1 MiB │     1 MiB │    0 B 
    asset │  77.8 KiB │  77.8 KiB │    0 B │ 109.3 KiB │ 109.3 KiB │    0 B 
    other │    78 KiB │    78 KiB │   -4 B │   154 KiB │   154 KiB │    0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
    total │    14 MiB │    14 MiB │ +146 B │  42.8 MiB │  42.8 MiB │ -180 B 


         │          raw           │           unique            
         ├────────┬────────┬──────┼────────┬────────┬───────────
 DEX     │ old    │ new    │ diff │ old    │ new    │ diff      
─────────┼────────┼────────┼──────┼────────┼────────┼───────────
   files │      3 │      3 │    0 │        │        │           
 strings │ 185345 │ 185345 │    0 │ 168652 │ 168652 │ 0 (+2 -2) 
   types │  32357 │  32357 │    0 │  30628 │  30628 │ 0 (+0 -0) 
 classes │  28301 │  28301 │    0 │  28301 │  28301 │ 0 (+0 -0) 
 methods │ 163956 │ 163956 │    0 │ 159416 │ 159416 │ 0 (+0 -0) 
  fields │ 116063 │ 116063 │    0 │ 115670 │ 115670 │ 0 (+0 -0) 


 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  295 │  295 │  0   
 entries │ 4369 │ 4369 │  0
APK
    compressed    │   uncompressed   │                                                       
─────────┬────────┼─────────┬────────┤                                                       
 size    │ diff   │ size    │ diff   │ path                                                  
─────────┼────────┼─────────┼────────┼───────────────────────────────────────────────────────
 3.4 MiB │ +150 B │ 9.9 MiB │ -180 B │ ∆ classes2.dex                                        
   186 B │   -4 B │     6 B │    0 B │ ∆ META-INF/androidx.activity_activity-compose.version 
─────────┼────────┼─────────┼────────┼───────────────────────────────────────────────────────
 3.4 MiB │ +146 B │ 9.9 MiB │ -180 B │ (total)
DEX
STRINGS:

   old    │ new    │ diff      
  ────────┼────────┼───────────
   168652 │ 168652 │ 0 (+2 -2) 
  
  + 
                          PaymentSheet cannot set up a PaymentIntent in status '
  + 
                          PaymentSheet cannot set up a SetupIntent in status '
  
  - 
                          A PaymentIntent with status='requires_payment_method' or 'requires_action is required.
                          The current SetupIntent has status '

yuki-stripe
yuki-stripe previously approved these changes Dec 4, 2021
@ccen-stripe ccen-stripe merged commit 94a1657 into master Dec 9, 2021
@ccen-stripe ccen-stripe deleted the paymentSheetStatus branch December 9, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants