Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable card saving by default in PaymentSheet #4515

Merged
merged 2 commits into from
Jan 21, 2022
Merged

Conversation

skyler-stripe
Copy link
Contributor

@skyler-stripe skyler-stripe commented Jan 20, 2022

Summary

This unchecks the save card for future payments by default.

Motivation

Matching iOS behavior here: https://github.com/stripe-ios/stripe-ios/pull/661

In the future we can explore making this a configuration once we have a response from legal.

Testing

  • Added tests
  • Modified tests
  • Manually verified

Changelog

This should be noted.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2022

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: none)
NEW: paymentsheet-example-release-pr.apk (signature: none)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │  11.9 MiB │  11.9 MiB │  0 B │  40.4 MiB │  40.4 MiB │  0 B 
     arsc │   1.6 MiB │   1.6 MiB │  0 B │   1.6 MiB │   1.6 MiB │  0 B 
 manifest │   2.6 KiB │   2.6 KiB │  0 B │  10.8 KiB │  10.8 KiB │  0 B 
      res │ 697.1 KiB │ 697.1 KiB │  0 B │   1.1 MiB │   1.1 MiB │  0 B 
    asset │  77.7 KiB │  77.7 KiB │ -1 B │ 109.2 KiB │ 109.1 KiB │ -1 B 
    other │  78.3 KiB │  78.3 KiB │ +2 B │   154 KiB │   154 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  14.3 MiB │  14.3 MiB │ +1 B │  43.3 MiB │  43.3 MiB │ -1 B 


         │          raw           │           unique            
         ├────────┬────────┬──────┼────────┬────────┬───────────
 DEX     │ old    │ new    │ diff │ old    │ new    │ diff      
─────────┼────────┼────────┼──────┼────────┼────────┼───────────
   files │      3 │      3 │    0 │        │        │           
 strings │ 188175 │ 188175 │    0 │ 170172 │ 170172 │ 0 (+0 -0) 
   types │  32855 │  32855 │    0 │  30848 │  30848 │ 0 (+0 -0) 
 classes │  28463 │  28463 │    0 │  28463 │  28463 │ 0 (+0 -0) 
 methods │ 165291 │ 165291 │    0 │ 160395 │ 160395 │ 0 (+0 -0) 
  fields │ 121281 │ 121281 │    0 │ 120608 │ 120608 │ 0 (+0 -0) 


 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  297 │  297 │  0   
 entries │ 5387 │ 5387 │  0
APK
   compressed   │  uncompressed  │                                                       
─────────┬──────┼─────────┬──────┤                                                       
 size    │ diff │ size    │ diff │ path                                                  
─────────┼──────┼─────────┼──────┼───────────────────────────────────────────────────────
   186 B │ +2 B │     6 B │  0 B │ ∆ META-INF/androidx.activity_activity-compose.version 
 5.4 KiB │ -1 B │ 5.3 KiB │ -1 B │ ∆ assets/dexopt/baseline.prof                         
─────────┼──────┼─────────┼──────┼───────────────────────────────────────────────────────
 5.6 KiB │ +1 B │ 5.3 KiB │ -1 B │ (total)

@skyler-stripe skyler-stripe merged commit b2c1efe into master Jan 21, 2022
@skyler-stripe skyler-stripe deleted the checkboxQuickFix branch January 21, 2022 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants