Update to kotlin 1.6 #4546
Merged
Update to kotlin 1.6 #4546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyler-stripe
requested review from
awush-stripe,
brnunes-stripe,
ccen-stripe and
michelleb-stripe
as code owners
|
Thanks for the heads up! Would you mind verifying all the following example apps are built and run correctly? |
awush-stripe
reviewed
Feb 2, 2022
| @@ -150,7 +150,7 @@ class PaymentCardTest { | |||
| fun isValidExpiry() { | |||
| val expDay = "01" | |||
| val expMonth = "02" | |||
| val expYear = "2022" | |||
| val expYear = "2025" | |||
There was a problem hiding this comment.
is it that time already?
There was a problem hiding this comment.
I gave you a few extra years this time.
skyler-stripe
changed the title
|
Diffuse output: |
Done and added a note about these in the description. |
skyler-stripe
changed the title
skyler-stripe
assigned brnunes-stripe, michelleb-stripe, ccen-stripe and awush-stripe and unassigned skyler-stripe
skyler-stripe
changed the title
awush-stripe
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This updates our repo to use kotlin 1.6.10. Most of the required changes were already done in an earlier PR I did here
The biggest thing this PR does is move some
@ExperimentalCoroutinesApiannotations. We're either required to tag all of the super class methods, interface declarations, abstract class versions of each method with the annotation or we can just add it to the top of the implementing class like I did. Some of the annotations that were failing the build are no longer required, so I removed them.Unfortunately we can't push this yet because it relies on a release candidate for compose. I'm making this PR so we can look at all of the changes I made and have a branch to do sanity tests if desired. I'll come back and change the dependency to a regular release once the compose lib is updated.
edit: compose has now been updated to support 1.6
Motivation
So we can use kotlin 1.6
Testing
ran
./gradlew :paymentsheet:testDebugUnitTest :payments-core:testDebugUnitTest :stripecardscan:testDebugUnitTest :stripe-ui-core:testDebugUnitTest :stripe-core:testDebugUnitTest :link:testDebugUnitTest :identity:testDebugUnitTest :camera-core:testDebugUnitTestto run tests locally.Tested that example, paymentsheet-example, stripecardscan-example and identity-example build and worked as I would expect them to. I tested basic flows for each of them for a quick sanity check.
Changelog
Added this to the change log.