Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track the main loop for cleanup #4548

Merged
merged 2 commits into from
Feb 3, 2022

Conversation

awush-stripe
Copy link
Collaborator

Summary

Track the main loop job for cleanup on cancel

Motivation

Make sure the main loop job is canceled when the scan is canceled.

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

ccen-stripe
ccen-stripe previously approved these changes Feb 3, 2022
@stripe-ci stripe-ci assigned awush-stripe and unassigned ccen-stripe Feb 3, 2022
@awush-stripe awush-stripe enabled auto-merge (squash) February 3, 2022 01:28
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2022

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: none)
NEW: paymentsheet-example-release-pr.apk (signature: none)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │  11.8 MiB │  11.8 MiB │  0 B │  40.1 MiB │  40.1 MiB │  0 B 
     arsc │   1.6 MiB │   1.6 MiB │  0 B │   1.6 MiB │   1.6 MiB │  0 B 
 manifest │   2.6 KiB │   2.6 KiB │  0 B │  10.8 KiB │  10.8 KiB │  0 B 
      res │ 697.1 KiB │ 697.1 KiB │  0 B │   1.1 MiB │   1.1 MiB │  0 B 
    asset │  77.8 KiB │  77.8 KiB │  0 B │ 109.2 KiB │ 109.2 KiB │  0 B 
    other │  78.3 KiB │  78.3 KiB │  0 B │   154 KiB │   154 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  14.2 MiB │  14.2 MiB │  0 B │    43 MiB │    43 MiB │  0 B 


         │          raw           │           unique            
         ├────────┬────────┬──────┼────────┬────────┬───────────
 DEX     │ old    │ new    │ diff │ old    │ new    │ diff      
─────────┼────────┼────────┼──────┼────────┼────────┼───────────
   files │      3 │      3 │    0 │        │        │           
 strings │ 188329 │ 188329 │    0 │ 170316 │ 170316 │ 0 (+0 -0) 
   types │  32883 │  32883 │    0 │  30876 │  30876 │ 0 (+0 -0) 
 classes │  28485 │  28485 │    0 │  28485 │  28485 │ 0 (+0 -0) 
 methods │ 165473 │ 165473 │    0 │ 160577 │ 160577 │ 0 (+0 -0) 
  fields │ 121355 │ 121355 │    0 │ 120682 │ 120682 │ 0 (+0 -0) 


 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  297 │  297 │  0   
 entries │ 5389 │ 5389 │  0

@awush-stripe awush-stripe merged commit 80849d2 into master Feb 3, 2022
@awush-stripe awush-stripe deleted the awush/track_main_loop_for_cleanup branch February 3, 2022 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants