Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix card add display bug #4575

Merged
merged 2 commits into from
Feb 10, 2022
Merged

Conversation

awush-stripe
Copy link
Collaborator

@awush-stripe awush-stripe commented Feb 10, 2022

Summary

Make sure the required card text does not show up for scans with no required card.

Motivation

The new card-add flow will display a required card: null without this change.

Testing

  • Added tests
  • Modified tests
  • Manually verified

Changelog

[FIXED] 4575 Fix card add display bug

@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2022

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: none)
NEW: paymentsheet-example-release-pr.apk (signature: none)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │    12 MiB │    12 MiB │  0 B │  40.7 MiB │  40.7 MiB │  0 B 
     arsc │   1.6 MiB │   1.6 MiB │  0 B │   1.6 MiB │   1.6 MiB │  0 B 
 manifest │   2.7 KiB │   2.7 KiB │  0 B │  11.1 KiB │  11.1 KiB │  0 B 
      res │ 697.8 KiB │ 697.8 KiB │  0 B │   1.1 MiB │   1.1 MiB │  0 B 
    asset │    78 KiB │    78 KiB │  0 B │ 109.5 KiB │ 109.5 KiB │  0 B 
    other │  78.3 KiB │  78.3 KiB │  0 B │   154 KiB │   154 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  14.4 MiB │  14.4 MiB │  0 B │  43.7 MiB │  43.7 MiB │  0 B 

         │          raw           │           unique            
         ├────────┬────────┬──────┼────────┬────────┬───────────
 DEX     │ old    │ new    │ diff │ old    │ new    │ diff      
─────────┼────────┼────────┼──────┼────────┼────────┼───────────
   files │      3 │      3 │    0 │        │        │           
 strings │ 196168 │ 196168 │    0 │ 172484 │ 172484 │ 0 (+0 -0) 
   types │  33381 │  33381 │    0 │  31245 │  31245 │ 0 (+0 -0) 
 classes │  28840 │  28840 │    0 │  28840 │  28840 │ 0 (+0 -0) 
 methods │ 167676 │ 167676 │    0 │ 162675 │ 162675 │ 0 (+0 -0) 
  fields │ 122905 │ 122905 │    0 │ 122186 │ 122186 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  298 │  298 │  0   
 entries │ 5394 │ 5394 │  0

@awush-stripe awush-stripe merged commit 1eafd3b into master Feb 10, 2022
@awush-stripe awush-stripe deleted the awush/fix_card_add_display_bug branch February 10, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants