Merge Project Wardrobe feature branch into master. #5020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add public api for project wardrobe * attempt #2 * change from floats to TextUnits for default typography * forgot typography * api dump
* Add public api for primary button * apidump * add nullables to make construction easier * update docs
* Add project wardrobe configs to init events * shorten config field to save url size
* address dogfooding comments * api dump
skyler-stripe
requested review from
brnunes-stripe,
michelleb-stripe and
jameswoo-stripe
as code owners
skyler-stripe
force-pushed
the
payment_sheet_appearance_beta_1
branch
from
4853a09
to
544d9ee
Compare
skyler-stripe
force-pushed
the
payment_sheet_appearance_beta_1
branch
from
544d9ee
to
19dac5f
Compare
skyler-stripe
changed the title
| toolbar.setBackgroundColor( | ||
| PaymentsThemeDefaults.colors(isDark).surface.toArgb() | ||
| ) | ||
| viewModel.config?.let { |
There was a problem hiding this comment.
Quick sanity check, did we check to make sure DKA works with this?
There was a problem hiding this comment.
Just checked and it still works. Good call though, I did a quick audit of all of the customization and it appears to work with DKA.
jameswoo-stripe
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds project wardrobe work to master. This has all been previously reviewed (see commit history for PR links)
Motivation
Testing
Ran unit tests and screenshot regression tests. Also manually tested each variable and rule via playground and manual edits.
Edit: also checked with DKA on.
Changelog