iDeal Source with connected account #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retrieveSource should create RequestOptions with stripeAccount if not null same as createSource
StripeApiHandler.retrieveSource(sourceId, clientSecret, apiKey, mStripeAccount);
|
Hi @ksun-stripe can you have a look at this? |
|
Any chance you can get this merged? @ksun-stripe @joel-stripe |
|
Experiencing exactly the same issue. Hopefully, this will get merged soon. |
mshafrir-stripe
requested changes
Dec 18, 2018
kirilsokolov
commented
Dec 19, 2018
mshafrir-stripe
approved these changes
Dec 20, 2018
|
Thank's a lot for this. |
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an iDeal source is created it uses the connected account (mStripeAccount) in the RequestOptions (StripeApiHandler:152).
But when you try go get the source status, although connected account is set, it's not used for RequestOptions resulting in exception com.stripe.android.exception.InvalidRequestException: No such source (StripeApiHandler:200).
With this modifications the checkSource passes with or without connected account.
This was not a problem with iOS or PHP version (maybe you can check why it works there).