Support 3 digit AMEX CVC input. #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joel-stripe
force-pushed
the
joel-3digitamex
branch
from
71fac7c
to
228d68e
Compare
ksun-stripe
approved these changes
Apr 10, 2018
| if (StripeTextUtils.isBlank(cvcValue) || cvcValue.length() != requiredLength) { | ||
| String cvcValue = mCvcNumberEditText.getText().toString().trim(); | ||
| int cvcLength = cvcValue.length(); | ||
| if (!(cvcLength == Card.CVC_LENGTH_COMMON |
There was a problem hiding this comment.
can we simplify this expression at all? I'm worried it'll be confusing down the line with all the nesting and the parts
One idea is we can either pull it into two functions
isCommonCSVLength() || isValidAmexCVC()
| boolean cvcIsValid = ViewUtils.isCvcMaximalLength( | ||
| mCardBrand, mCvcEditText.getText().toString()); | ||
| int cvcLength = mCvcEditText.getText().toString().trim().length(); | ||
| boolean cvcIsValid = cvcLength == Card.CVC_LENGTH_COMMON |
There was a problem hiding this comment.
can we simplify this at all? This looks confusing and I'm concern it will be hard to maintain.
One option is to pull this into a self documenting helper function and to write some tests for it because then we will be able to know what the expression is expected to resolve to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.corp.stripe.com/browse/ANDROID-220