Preserve payment selection for guests #5480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillh-stripe
commented
Aug 29, 2022
Comment on lines
144
to
117
| private fun createWithoutCustomer( | ||
| clientSecret: ClientSecret, | ||
| stripeIntent: StripeIntent, | ||
| config: PaymentSheet.Configuration?, | ||
| isGooglePayReady: Boolean, | ||
| isLinkReady: Boolean | ||
| ): FlowControllerInitializer.InitResult { | ||
| val savedSelection = if (isLinkReady) { | ||
| SavedSelection.Link | ||
| } else if (isGooglePayReady) { | ||
| SavedSelection.GooglePay | ||
| } else { | ||
| SavedSelection.None | ||
| } |
There was a problem hiding this comment.
Removed this logic for guests, because we can just use setLastSavedPaymentMethod() for this.
tillh-stripe
commented
Aug 30, 2022
| @@ -239,7 +239,7 @@ class LinkPaymentLauncher @AssistedInject internal constructor( | |||
|
|
|||
| @RestrictTo(RestrictTo.Scope.LIBRARY_GROUP) | |||
| companion object { | |||
| val LINK_ENABLED = BuildConfig.DEBUG | |||
| val LINK_ENABLED = false | |||
There was a problem hiding this comment.
Had to revert my earlier change because this breaks the PaymentOptionsActivityTest.
tillh-stripe
force-pushed
the
tillh/initializer-guest-payment-method-selection
branch
from
e62b83e
to
483614f
Compare
tillh-stripe
requested review from
brnunes-stripe,
michelleb-stripe,
jameswoo-stripe,
ccen-stripe and
awush-stripe
as code owners
brnunes-stripe
previously approved these changes
Sep 8, 2022
tillh-stripe
force-pushed
the
tillh/initializer-guest-payment-method-selection
branch
from
483614f
to
2cdcc4a
Compare
| @@ -242,7 +242,7 @@ class LinkPaymentLauncher @AssistedInject internal constructor( | |||
|
|
|||
| @RestrictTo(RestrictTo.Scope.LIBRARY_GROUP) | |||
| companion object { | |||
| val LINK_ENABLED = BuildConfig.DEBUG | |||
| val LINK_ENABLED = false | |||
There was a problem hiding this comment.
Revert this change?
There was a problem hiding this comment.
Nope, unfortunately had to do this to stop PaymentOptionsActivityTest from failing.
brnunes-stripe
approved these changes
Sep 9, 2022
tillh-stripe
deleted the
tillh/initializer-guest-payment-method-selection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes a bug where the
FlowControllerwould show an incorrect payment method selection for guests that don’t have any saved payment methods.Previously, we would use
PrefsRepository.NoOpwhen no customer ID was provided to our SDK. Now, we useDefaultPrefsRepositoryand store a guest’s last saved payment method under a generic"guest"key. This is similar to iOS, which uses an empty string.Motivation
Bugfix.
Testing
Screen recordings
Before
The payment options sheet would default to Google Pay, even if Link was available and had been previously selected.
old-behavior.mp4
After
The payment options sheet now correctly shows link as the current payment selection when opening the sheet.
new-behavior.mp4
Changelog
[Fixed]
FlowControllernow correctly preserves the previously selected payment method for guests.